Skip to content

Commit

Permalink
Updated help docs to show EventSub topics instead of aliases. Previou…
Browse files Browse the repository at this point in the history
…s aliases still work, but are not prreferred to be used by users going forward.
  • Loading branch information
Xemdo committed Feb 15, 2023
1 parent 78ce45b commit e7c5e07
Show file tree
Hide file tree
Showing 30 changed files with 198 additions and 74 deletions.
9 changes: 5 additions & 4 deletions cmd/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/twitchdev/twitch-cli/internal/events"
"github.com/twitchdev/twitch-cli/internal/events/mock_wss_server"
"github.com/twitchdev/twitch-cli/internal/events/trigger"
"github.com/twitchdev/twitch-cli/internal/events/types"
"github.com/twitchdev/twitch-cli/internal/events/verify"
"github.com/twitchdev/twitch-cli/internal/util"
)
Expand Down Expand Up @@ -54,9 +55,9 @@ var triggerCmd = &cobra.Command{
Short: "Creates mock events that can be forwarded to a local webserver for event testing.",
Long: fmt.Sprintf(`Creates mock events that can be forwarded to a local webserver for event testing.
Supported:
%s`, events.ValidTriggers()),
%s`, types.AllEventTopics()),
Args: cobra.MaximumNArgs(1),
ValidArgs: events.ValidTriggers(),
ValidArgs: types.AllEventTopics(),
Run: triggerCmdRun,
Example: `twitch event trigger subscribe`,
Aliases: []string{
Expand All @@ -69,9 +70,9 @@ var verifyCmd = &cobra.Command{
Short: "Mocks the subscription verification event. Can be forwarded to a local webserver for testing.",
Long: fmt.Sprintf(`Mocks the subscription verification event that can be forwarded to a local webserver for testing.
Supported:
%s`, events.ValidTriggers()),
%s`, types.AllEventTopics()),
Args: cobra.MaximumNArgs(1),
ValidArgs: events.ValidTriggers(),
ValidArgs: types.AllEventTopics(),
Run: verifyCmdRun,
Example: `twitch event verify-subscription subscribe`,
Aliases: []string{
Expand Down
17 changes: 3 additions & 14 deletions internal/events/cmd_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,9 @@
// SPDX-License-Identifier: Apache-2.0
package events

import "sort"

func ValidTriggers() []string {
names := []string{}

for name, enabled := range triggerSupported {
if enabled == true {
names = append(names, name)
}
}
sort.Strings(names)

return names
}
import (
"sort"
)

func ValidTransports() []string {
names := []string{}
Expand Down
7 changes: 0 additions & 7 deletions internal/events/cmd_helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@ import (
"github.com/twitchdev/twitch-cli/test_setup"
)

func TestValidTriggers(t *testing.T) {
a := test_setup.SetupTestEnv(t)

t1 := ValidTriggers()
a.NotEmpty(t1)
}

func TestValidTransports(t *testing.T) {
a := test_setup.SetupTestEnv(t)

Expand Down
3 changes: 3 additions & 0 deletions internal/events/event.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ type MockEvent interface {
// Returns whether a given event supports a supplied transport
ValidTransport(transport string) bool

// Returns
GetAllTopicsByTransport(transport string) []string

// Returns the string of the topic
GetTopic(transport string, trigger string) string

Expand Down
47 changes: 0 additions & 47 deletions internal/events/models.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,53 +2,6 @@
// SPDX-License-Identifier: Apache-2.0
package events

var triggerSupported = map[string]bool{
"add-moderator": true,
"add-redemption": true,
"add-reward": true,
"ban": true,
"charity-donate": true,
"charity-progress": true,
"charity-start": true,
"charity-stop": true,
"cheer": true,
"drop": true,
"follow": true,
"gift": true,
"goal-begin": true,
"goal-end": true,
"goal-progress": true,
"grant": true,
"hype-train-begin": true,
"hype-train-end": true,
"hype-train-progress": true,
"poll-begin": true,
"poll-progress": true,
"poll-end": true,
"prediction-begin": true,
"prediction-progress": true,
"prediction-lock": true,
"prediction-end": true,
"raid": true,
"remove-moderator": true,
"remove-reward": true,
"revoke": true,
"shield-mode-begin": true,
"shield-mode-end": true,
"shoutout-create": true,
"shoutout-received": true,
"stream-change": true,
"streamdown": true,
"streamup": true,
"subscribe": true,
"transaction": true,
"unban": true,
"unsubscribe": true,
"update-redemption": true,
"update-reward": true,
"user-update": true,
}

var transportSupported = map[string]bool{
"websub": false,
"eventsub": true,
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/authorization/authorization.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/ban/ban.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/channel_points_reward/reward_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/charity/charity_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,13 @@ func (e Event) ValidTrigger(trigger string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/cheer/cheer_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/drop/drop.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/follow/follow_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ func (e Event) ValidTrigger(trigger string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/gift/channel_gift.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
8 changes: 8 additions & 0 deletions internal/events/types/goal/goal_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,14 @@ func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}

func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}

func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/hype_train/hype_train_event.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/poll/poll.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}

func intPointer(i int) *int {
return &i
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/prediction/prediction.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}

func intPointer(i int) *int {
return &i
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/raid/raid.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ func (e Event) ValidTrigger(t string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/shield_mode/shield_mode.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,13 @@ func (e Event) ValidTrigger(trigger string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
7 changes: 7 additions & 0 deletions internal/events/types/shoutout/shoutout.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@ func (e Event) ValidTrigger(trigger string) bool {
func (e Event) GetTopic(transport string, trigger string) string {
return triggerMapping[transport][trigger]
}
func (e Event) GetAllTopicsByTransport(transport string) []string {
allTopics := []string{}
for _, topic := range triggerMapping[transport] {
allTopics = append(allTopics, topic)
}
return allTopics
}
func (e Event) GetEventSubAlias(t string) string {
// check for aliases
for trigger, topic := range triggerMapping[models.TransportEventSub] {
Expand Down
Loading

0 comments on commit e7c5e07

Please sign in to comment.