Fix tests, add travis, no ips means all ips #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some tests, then adds travis to make sure they don't break again. To try travis I think you just need enable travis for this repo, then close and reopen this PR to get it picked up.
It also undoes a (possibly unintentional, cc @roman-kashitsyn) change from https://github.com/tylertreat/comcast/pull/34/files#diff-37cc0cdfa4b91e523551b72469d7abeaR129 where previously passing no IP addresses applies rules to all IPs, but afterwards it would apply to none (the iptables commands wouldn't be run at all). This manifests in the form of packet loss options not applying, though bandwidth limits still happen.