-
Notifications
You must be signed in to change notification settings - Fork 4.2k
WIP: Implement Docssaurus #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
that github preview seems broken - wanna use Netlify or something else? |
Indeed. I was trying to set it up via |
@sw-yx I think now it's working. Could you take a look and share your thoughts about it? Just to see if I should continue in this way. |
I have pre-commit hooks disabled globally and others might too. Why do we need to disable the action? |
lol... I didn't know it's even possible to disable git hooks globally. I mean, it's a clear step, right? Why should a commit not formatted be committed? I just propose to skip this kind of simple validation. But knowing that, I'll keep both |
lookin good! its coming along! |
@sw-yx I think I have the bare minimum. Only missing HOC + Migration but now I need some guidance how you see yourself writing these guides. I'll drop some questions bellow. If you and/or more maintainers can discuss about each topic would be amazing. I don't want to take core decisions without the opinion from the ones which maintain that.
Also just take a look on it and share what could be different, or better. |
I don't want to argue personal workflow. A bad commit shouldn't be merged into master which is why we have CI via github actions. The state of the PR during development is not relevant. |
@eps1lon Rolled it back! |
|
Nice! Well, so a catch up about what I did:
SearchAbout searching, maybe this should be the last step. It'll be necessary you or someone submit the following form asking this service to Algolia. Then, we'll get the API keys and enable search into TranslationsDocussaurus uses Crowdin to provide translations. It's a paid service but for open source projects, it's free due a form submission. |
ok awesome i'll try to set that Algolia thing up. i've loaded myself up with a big project that is keeping me super busy, sorry for the delayed response - I'm gonna merge this in now, thanks for the initial lift and we'll announce this when we have the site up with Algolia! |
TODO
side_title
+title
see our [Commenting Components](/ADVANCED.md#commenting-components)
)Changes
Remove action prettier validation in favor of pre-hook prettier format. In that way every file committed will be already well formatted;Before merge
GITHUB_TOKEN
keyPoints to discuss