-
Notifications
You must be signed in to change notification settings - Fork 4.2k
adding contributors page on website #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks! haha I don't love the idea of tacking on the cp npm script but this works well enough. I would suggest also adding the contributors to the sidebar nav instead of just the footer. I might also try to flesh it out a bit with a call to action on how to contribute (ask a question, answer a question, ask for clarification, help reorganize and update links, etc). basically we might want to expose our CONTRIBUTING.MD too and update it. maybe merge it with this contributors page. what do you think? |
Yes, I am going to update the the initial idea, as you suggested:
And then I believe it can merged) |
great job so far! |
- add contributing to footer - add hide title for copied pages to avoid double titles - change cp to native nodejs script
Error Error
Dangerfile
|
@sw-yx thank you! I added the code, it works fine, meanwhile danger-cli can't resolve copyFile.js for some reason. We can try to run action script again after merge to confirm that it is cli bug or fix it, if it isn't. |
thanks @Winner95! yes we can check and fix after we merge. @all-contributors please add @Winner95 for code! |
I've put up a pull request to add @Winner95! 🎉 |
👋 Hello @sw-yx ,
I saw #333 and decided to provide a possible solution - probably still prototype, but it is working:)
The idea is to take existing list of contributors and reuse it in source of website generation. As entry point on the website it can be added in footer menu under the 'Community' section.
Hope this works)