Skip to content

adding contributors page on website #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

Winner95
Copy link
Collaborator

@Winner95 Winner95 commented Oct 5, 2020

👋 Hello @sw-yx ,

I saw #333 and decided to provide a possible solution - probably still prototype, but it is working:)

The idea is to take existing list of contributors and reuse it in source of website generation. As entry point on the website it can be added in footer menu under the 'Community' section.

Hope this works)

@swyxio
Copy link
Collaborator

swyxio commented Oct 6, 2020

thanks! haha I don't love the idea of tacking on the cp npm script but this works well enough. I would suggest also adding the contributors to the sidebar nav instead of just the footer. I might also try to flesh it out a bit with a call to action on how to contribute (ask a question, answer a question, ask for clarification, help reorganize and update links, etc). basically we might want to expose our CONTRIBUTING.MD too and update it. maybe merge it with this contributors page. what do you think?

@Winner95
Copy link
Collaborator Author

Winner95 commented Oct 6, 2020

Yes, I am going to update the the initial idea, as you suggested:

  1. use instead env-based cp some script from npm
  2. add to sidebar menu item
  3. expose contributing page to the source as well

And then I believe it can merged)

@swyxio
Copy link
Collaborator

swyxio commented Oct 6, 2020

great job so far!

- add contributing to footer
- add hide title for copied pages to avoid double titles
- change cp to native nodejs script
@danger-public
Copy link

Fails
🚫

Danger failed to run dangerfile.js.

Error Error

ENOENT: no such file or directory, open 'copyFile.js'
Error: ENOENT: no such file or directory, open 'copyFile.js'
    at Object.openSync (fs.js:462:3)
    at readFileSync (fs.js:364:35)
    at dangerfile.js:7:19
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (dangerfile.js:6:8)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.requireFromString [as default] (/home/runner/work/react/react/node_modules/require-from-string/index.js:28:4)
    at Object.<anonymous> (/home/runner/work/react/react/node_modules/danger/distribution/runner/runners/inline.js:144:63)
    at step (/home/runner/work/react/react/node_modules/danger/distribution/runner/runners/inline.js:32:23)
    at Object.next (/home/runner/work/react/react/node_modules/danger/distribution/runner/runners/inline.js:13:53)

Dangerfile

------^

Generated by 🚫 dangerJS against c362b30

@Winner95
Copy link
Collaborator Author

Winner95 commented Oct 6, 2020

@sw-yx thank you!

I added the code, it works fine, meanwhile danger-cli can't resolve copyFile.js for some reason.

We can try to run action script again after merge to confirm that it is cli bug or fix it, if it isn't.

@swyxio
Copy link
Collaborator

swyxio commented Oct 7, 2020

thanks @Winner95! yes we can check and fix after we merge.

@all-contributors please add @Winner95 for code!

@swyxio swyxio merged commit 28e7b65 into typescript-cheatsheets:main Oct 7, 2020
@allcontributors
Copy link
Contributor

@sw-yx

I've put up a pull request to add @Winner95! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants