Skip to content

chore: Update danger token #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: Update danger token #396

wants to merge 2 commits into from

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 17, 2021

Part of #395

Created a new account. Will share credentials in an internal team discussion. Followed the official docs in which we don't need a separate token apparently.

eps1lon added 2 commits March 17, 2021 09:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@eps1lon eps1lon requested a review from orta March 17, 2021 08:30
@orta
Copy link
Collaborator

orta commented Mar 17, 2021

This'll only work for same branch PRs because of the GH actions security settings, so it's not a reasonable answer I'm afraid though danger/danger-js#1125 should fix it, it needs a new token, looks like someone got that public token revoked

@zhirzh zhirzh mentioned this pull request Mar 17, 2021
@swyxio
Copy link
Collaborator

swyxio commented Mar 17, 2021

i maybe dont fully understand this but don't Github actions themselves have access to Checks API/their own token for doing whatever? anyway i'm standing by to do whatever needed if i need to add a Personal Access Token via secrets i can do that

@eps1lon
Copy link
Member Author

eps1lon commented Mar 17, 2021

should fix it, it needs a new token, looks like someone got that public token revoked

@orta I did add a new token with public_repo in 74c4fe7 (#396) but that failed as well: https://github.com/typescript-cheatsheets/react/runs/2128883490

@eps1lon
Copy link
Member Author

eps1lon commented Apr 5, 2021

@orta Any idea why the new token is insufficient? Is https://danger.systems/js/guides/getting_started.html#tokens-for-oss-projects still up-to-date?

@stale
Copy link

stale bot commented Jun 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the wontfix This will not be worked on label Jun 4, 2021
@eps1lon eps1lon mentioned this pull request Jun 7, 2021
@eps1lon eps1lon closed this in #426 Jun 7, 2021
@eps1lon eps1lon deleted the eps1lon-patch-1 branch June 7, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants