-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to dependency tree to React 17 and added mui (material-ui v5) widget collection #505
Conversation
…conflicting react versions
Sneaking build-npm script that needs to copy config index.d.ts
Thanks for PR. |
@ukrbublik Good idea. That's probably a better way to do it. I'll try to put something together. |
A couple notes on the changes since this PR first occurred: Since the new updates to main, I was able to to pass Please note that the points from above still exist in this PR due to the fact that MUI v5 supports at a minimum React 17.0.2
|
Looking into why smoke timed out here but didn't on my machine... |
Copied to #628 with fixes |
enzyme-adapter-react-17
deps were incompatible with React 17.0.2, I forked my own version and manually changed the dependency tree. It's currently in package.json with a direct GitHub link.sandbox
scripts. I'm not too familiar with sandbox and I was getting a this error:I'm not familiar with sandbox and maybe it was an issue with my machine. This was the only reason that I could not get
npm run smoke
to finish successfully, but everything worked other than that aspect.Since
@mui/lab
also exports@date-io
, I had to enableskipLibCheck
in tsconfig because of the duplicate interfaces, although they are the same.There does not yet exists a
@hot-loader/react-dom
for React 17.0.2 yet, so I temporarily commented out that functionality on dev instances.There's a lot of stuff here an I'm happy to edit stuff as needed. This is an awesome package.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: