Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update doc #2511

Merged
merged 14 commits into from
Sep 2, 2024
Merged

Fix/update doc #2511

merged 14 commits into from
Sep 2, 2024

Conversation

madtoinou
Copy link
Collaborator

@madtoinou madtoinou commented Aug 27, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2234, fixes #2276, fixes #2487, fixes #2193.

Summary

  • Indicate that multi_lags=False will induce a shift of the lags for each step in output_chunk_length
  • Added reference to timeseries_generation.datetime_attribute_timeseries in TimeSeries.add_datetime_attribute (reflect change of behavior; every encoding is now 0-indexed)
  • Update the examples to reflect the deprecation of num_loader_workers and the introduction of kwargs_dataloader.
  • Made CrostonModel a LocalForecastingModel instead of a FutureCovariatesLocalFM since the future covariates are actually leveraged only when conformal prediction is used, updated the table of models accordingly
  • Added a new issue template for questions about documentation or features

Other Information

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (3e893cd) to head (b3b874e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2511      +/-   ##
==========================================
- Coverage   93.80%   93.78%   -0.02%     
==========================================
  Files         139      139              
  Lines       14742    14727      -15     
==========================================
- Hits        13828    13812      -16     
- Misses        914      915       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @madtoinou. Thanks a lot for the fixes :) Only some minor comments

.github/ISSUE_TEMPLATE/question.md Outdated Show resolved Hide resolved
darts/models/forecasting/linear_regression_model.py Outdated Show resolved Hide resolved
examples/14-transfer-learning.ipynb Outdated Show resolved Hide resolved
examples/17-hyperparameter-optimization.ipynb Outdated Show resolved Hide resolved
@madtoinou madtoinou merged commit 26c5f39 into master Sep 2, 2024
9 checks passed
@madtoinou madtoinou deleted the fix/update_doc branch September 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants