-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update doc #2511
Fix/update doc #2511
Conversation
…diction, changed it from FutureCovLocalModel to LocalModel
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2511 +/- ##
==========================================
- Coverage 93.80% 93.78% -0.02%
==========================================
Files 139 139
Lines 14742 14727 -15
==========================================
- Hits 13828 13812 -16
- Misses 914 915 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @madtoinou. Thanks a lot for the fixes :) Only some minor comments
Checklist before merging this PR:
Fixes #2234, fixes #2276, fixes #2487, fixes #2193.
Summary
multi_lags=False
will induce a shift of the lags for each step inoutput_chunk_length
timeseries_generation.datetime_attribute_timeseries
inTimeSeries.add_datetime_attribute
(reflect change of behavior; every encoding is now 0-indexed)num_loader_workers
and the introduction ofkwargs_dataloader
.CrostonModel
aLocalForecastingModel
instead of aFutureCovariatesLocalFM
since the future covariates are actually leveraged only when conformal prediction is used, updated the table of models accordinglyOther Information