Fix URL reading issue in [..url]/page.tsx #99
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update page.tsx - replace "//" with "/" in decodedComponents.join() - url was not reading before and the bot wouldn't answer questions correctly.
|
Hi there, I was able to make it work with both If you try again with If that doesn't solve the issue, can you share the URL you were trying with so that I can reproduce the issue? |
|
Hi, it wasn't working on any wikipedia link (the rag bot would take the
wikipedia home page, and give the response "the linked page doesn't appear
to have any information about [x] but is instead the wikipedia home page
with links" etc.).
After changing the // to / it works perfectly fine with any link.
I was trying with this link https://en.wikipedia.org/wiki/Vestland but hen
tried it with many others, upon my change it works with any link as
mentioned.
Good luck!
…On Fri, 10 Jan 2025 at 09:53, Cahid Arda Öz ***@***.***> wrote:
Hi there, I was able to make it work with both / and //. I am testing
with
https://raw.githubusercontent.com/upstash/docs/refs/heads/main/workflow/basics/caveats.mdx
.
If you try again with //, can you flush the redis db so that the website
doesn't think the url is already index and skip indexing?
If that doesn't solve the issue, can you share the URL you were trying
with so that I can reproduce the issue?
—
Reply to this email directly, view it on GitHub
<#99 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYN5I5Q753PJ2IVRTJ6Q4A32J6KDFAVCNFSM6AAAAABUAVUCWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBSGIZTQMZSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I see, I was able to reproduce the issue and using |
CahidArda
approved these changes
Jan 17, 2025
|
Awesome, thanks for the update!
…On Fri, 17 Jan 2025, 12:18 Cahid Arda Öz, ***@***.***> wrote:
Merged #99 <#99> into master.
—
Reply to this email directly, view it on GitHub
<#99 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYN5I5QTFCNQZ5YGMEPPKPT2LDYKPAVCNFSM6AAAAABUAVUCWCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHE3TMNRXGAZDANI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update page.tsx - replace "//" with "/" in decodedComponents.join() - url was not reading before and the bot wouldn't answer questions correctly.