Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incompatible CLI usage since v5 #246

Merged
merged 2 commits into from
Sep 16, 2022
Merged

fix: incompatible CLI usage since v5 #246

merged 2 commits into from
Sep 16, 2022

Conversation

digglife
Copy link
Contributor

@digglife digglife commented Sep 8, 2022

CLI interface has been changed since v5, so we need to make the script work for both v4 and v5.

fixes: #243

@digglife
Copy link
Contributor Author

digglife commented Sep 9, 2022

@IceCodeNew could you please review the code?

@digglife
Copy link
Contributor Author

digglife commented Sep 13, 2022

@kslr @nicholascw

Do you have the authorization to review and merge PR for this repo? Not sure why @IceCodeNew didn't respond.

The script is one of the recommended ways to install v2ray on Linux, yet this issue has been out there for a week without actions from maintainers. Kind of abnormal because it's quite critical.

@dctxmei
Copy link
Contributor

dctxmei commented Sep 15, 2022

@digglife I sent a PR (digglife#1) to your repository and it is working fine with me :)

@digglife
Copy link
Contributor Author

@digglife I sent a PR (digglife#1) to your repository and it is working fine with me :)

I don't get it. What's the issue you tried to fix with that?

@dctxmei
Copy link
Contributor

dctxmei commented Sep 15, 2022 via email

@digglife
Copy link
Contributor Author

@dctxmei Got it. I didn't notice that v2ctl is gone. Thanks!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
v2ctl has been removed since v5, so the script will fail during removing.

```
rm: cannot remove '/usr/local/bin/v2ctl': No such file or directory
error: Failed to remove V2Ray.
```
@kslr kslr merged commit a9c7b8d into v2fly:master Sep 16, 2022
@kslr
Copy link
Contributor

kslr commented Sep 16, 2022

Sorry, I've been a bit down lately and haven't been following github.

This was referenced Sep 16, 2022
@digglife
Copy link
Contributor Author

Sorry, I've been a bit down lately and haven't been following github.

No problem. Thanks for your time. Hope you feel better soon!

abt12680 added a commit to v2ssrlis/fhs-install-v2ray that referenced this pull request Oct 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix: incompatible CLI usage since v5 (v2fly#246)
@IceCodeNew IceCodeNew mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2ray 5.0问题。
3 participants