Port support for spaceman 2% milk macropad #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesshonor
approved these changes
Sep 9, 2023
1c2b4f6 to
b04652c
Compare
|
Thanks for reviewing. I have addressed both of your comments and squashed the commits. Happy for you to merge when ready. |
lesshonor
approved these changes
Sep 10, 2023
|
I think everything is ready now, and it can be added to the repository. If I have made any mistakes or need to make corrections, please point them out, and I will do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially just ported the existing via keymap for vial, with couple of extra defines to bring the firmware size down to fit on a pro micro.