-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misc fix for vite 6 ecosystem ci #6867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
force-pushed
the
fix-eco-ci-6
branch
from
November 11, 2024 02:54
d1dda8e
to
6e7953d
Compare
6 tasks
hi-ogawa
force-pushed
the
fix-eco-ci-6
branch
from
November 14, 2024 01:34
fa66d6e
to
9d858c1
Compare
hi-ogawa
force-pushed
the
fix-eco-ci-6
branch
from
November 14, 2024 01:35
9d858c1
to
e6ee7ac
Compare
sheremet-va
approved these changes
Nov 14, 2024
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vite ecosystem CI has been failing. Trying to collect what was the reason and maybe add a quick fix if possible.
__vite_ssr_identity__
wrapperresolve.mainFields
andresolve.conditions
for SSR environment #6896immutable
package import errorFor temporary skipped tests, I'll open a separate PR to address these.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.