Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown files are not rebuilt when their "includes" change #4289

Closed
4 tasks done
everdimension opened this issue Oct 15, 2024 · 4 comments
Closed
4 tasks done

Markdown files are not rebuilt when their "includes" change #4289

everdimension opened this issue Oct 15, 2024 · 4 comments
Labels
bug Something isn't working build Related to the build system

Comments

@everdimension
Copy link

everdimension commented Oct 15, 2024

Describe the bug

I have the following vitepress structure:

docs-vitepress
├── endpoints.md
├── entities.md
├── generated
│   ├── endpoints.md
│   └── entities.md
├── index.md
└── overview.md

enpoints.md simply contains an include of ./generated/endpoints.md:

<!--@include: ./generated/endpoints.md-->

This is done to avoid the /generated/ path segment in the URL.

Problem: When content of /generated/endpoints.md changes, content of /endpoints.md doesn't change

Reproduction

https://github.com/everdimension/vitepress-watch-included-issue

Expected behavior

It's expected that when content of /generated/endpoints.md changes, the updates will be reflected in the build

System Info

OS: macOS 13.5.1
Memory: 16 GiB
Architecture: aarch64


  System:
    OS: macOS 13.5.1
    CPU: (8) x64 Apple M1
    Memory: 25.73 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0
    Yarn: 1.22.19
    npm: 10.2.5
  Browsers:
    Chrome Canary: 131.0.6778.0
    Safari: 16.6
  npmPackages:
    vitepress: ^1.4.1 => 1.4.1

Additional context

No response

Validations

@everdimension everdimension added the bug: pending triage Maybe a bug, waiting for confirmation label Oct 15, 2024
@brc-dd
Copy link
Member

brc-dd commented Oct 15, 2024

#2581

@brc-dd brc-dd closed this as completed Oct 15, 2024
@everdimension
Copy link
Author

Awesome, thanks!

I didn't find this in the docs

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
@vuejs vuejs unlocked this conversation Oct 29, 2024
@brc-dd brc-dd reopened this Oct 29, 2024
@brc-dd
Copy link
Member

brc-dd commented Oct 29, 2024

Ok this has regressed. Actually you shouldn't be needing any extra config. I just saw my old comment - #117 (comment)

Update: caused by - c46e4b7

@brc-dd brc-dd added bug Something isn't working build Related to the build system and removed bug: pending triage Maybe a bug, waiting for confirmation labels Oct 29, 2024
@brc-dd brc-dd closed this as completed in 615aed5 Oct 29, 2024
@brc-dd
Copy link
Member

brc-dd commented Oct 29, 2024

Fixed in latest version. You can remove that additional config. It's not needed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working build Related to the build system
Projects
None yet
Development

No branches or pull requests

2 participants