Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create language packs if project is active #144

Merged
merged 6 commits into from
Dec 21, 2018

Conversation

grappler
Copy link
Contributor

Description
Fixes #138

How has this been tested?

  • Ran docker-compose run cli wp --allow-root --url=translate.required.com.docker.amazee.io traduttore project build prohelvetia/ph-offices-abroad on a project that I marked as inactive.
  • Updated translations and checked that no cron job is scheduled. docker-compose run cli wp --allow-root --url=translate.required.com.docker.amazee.io cron event list

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.
Siteproxy
@grappler grappler requested a review from swissspidy December 21, 2018 09:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: grappler <grapplerulrich@gmail.com>
@swissspidy
Copy link
Collaborator

That GitHub suggestion feature messed up the indentation it seems 🤦‍♂️

Verified

This commit was signed with the committer’s verified signature. The key has expired.
swissspidy Pascal Birchler

Verified

This commit was signed with the committer’s verified signature. The key has expired.
swissspidy Pascal Birchler
@codecov-io
Copy link

Codecov Report

Merging #144 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
+ Coverage     79.68%   79.79%   +0.11%     
- Complexity      372      379       +7     
============================================
  Files            24       24              
  Lines           891      896       +5     
============================================
+ Hits            710      715       +5     
  Misses          181      181
Impacted Files Coverage Δ Complexity Δ
inc/Project.php 100% <100%> (ø) 53 <1> (+1) ⬆️
inc/Plugin.php 37.67% <100%> (+1.3%) 54 <0> (+6) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209c06d...8e2f2f6. Read the comment docs.

@swissspidy swissspidy merged commit 41cc7c3 into master Dec 21, 2018
@delete-merged-branch delete-merged-branch bot deleted the 138-active-projects branch December 21, 2018 10:29
@grappler grappler added this to the 3.0.0 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants