Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: cannot append third party scripts into html by using html tags while set config html inject: false #4015

Closed
sbyps opened this issue Nov 19, 2024 · 1 comment · Fixed by #4049
Labels
bug Something isn't working

Comments

@sbyps
Copy link

sbyps commented Nov 19, 2024

Version

System:
    OS: macOS 14.6.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 90.97 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 130.0.6723.117
    Safari: 17.6

Details

when we set config html inject: false, build scripts will not append into html;
but we also want to append third party scripts, and cannot work well while set config html inject: false;

Reproduce link

https://github.com/sbyps/rspack-demo/tree/test

Reproduce Steps

pnpm i
pnpm build
cat dist/index.html
cannot append eruda script file

@sbyps sbyps added the bug Something isn't working label Nov 19, 2024
@chenjiahan
Copy link
Member

This is as expected, I have updated the documentation to make it clearer: #4049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants