feat(command): support --lib arguments #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #390 will not alter performanceComparing Summary
|
| @@ -58,6 +72,11 @@ export function runCli(): void { | |||
|
|
|||
| inspectCommand | |||
| .description('inspect the Rsbuild / Rspack configs of Rslib projects') | |||
| .option( | |||
| '--lib <name>', | |||
There was a problem hiding this comment.
shared options can be set in CommonOptions
There was a problem hiding this comment.
There's a bit difference in the text.
'build the specified library (may be repeated)',
'inspect the specified library (may be repeated)',There was a problem hiding this comment.
use choose the specified library is enough, and what is may be repeated mean?
| @@ -58,6 +59,7 @@ inspect the Rsbuild / Rspack configs of Rslib projects | |||
| Options: | |||
| -c --config <config> specify the configuration file, can be a relative or absolute path | |||
| --env-mode <mode> specify the env mode to load the `.env.[mode]` file | |||
| --lib <name> build the specified library (may be repeated) | |||
There was a problem hiding this comment.
We should add docs about what name is.
Timeless0911
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #382.
Support following CLI args for
buildandinspect, only build specified lib. Could also be used withrslib mf devin #349.Related Links
Checklist