Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor web socket communication tests to cleanup properly #4920

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

As per #4847

Breaking Changes

No

Additional Info

No

Siteproxy
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (b7f7f1a) 91.91% compared to head (dfda90d) 91.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4920      +/-   ##
==========================================
- Coverage   91.91%   91.78%   -0.13%     
==========================================
  Files          15       15              
  Lines        1571     1571              
  Branches      594      594              
==========================================
- Hits         1444     1442       -2     
- Misses        118      120       +2     
  Partials        9        9              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snitin315 snitin315 merged commit f34c1c7 into next Jun 24, 2023
@snitin315 snitin315 deleted the test/web-socket-communication-cleanup branch June 24, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant