Make libmaia compatible with Qt6 #21
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b7dfd0 to
672df30
Compare
The method `QVariant::Type QVariant::type() const` has been deprecated since Qt 6.0. The recommended replacement is `typeId()` or `metaType()`, but these are not available under Qt5. So choose to use `userType()` instead, which is available under both and should cover the use cases as well.
The method `int QMetaType::type(const QByteArray &typeName)` has been deprecated since Qt 6.0. The only replacement is the new method `fromName()` introduced in Qt6, so the only solution is to use dedicated code for each Qt version until we stop supporting Qt5.
wiedi
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the Qt version that's looked for in CMake configurable.
Adjusts the source code to differences in Qt6.
Some functionality that is used in libmaia is deprecated in Qt6, but it continues to work. Some follow-up PR will need to fix the deprecations.