Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nb::ndarray: adding size, shape_ptr, stride_ptr members #161

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

tdegeus
Copy link
Contributor

@tdegeus tdegeus commented Mar 30, 2023

Fixes #158

I was not sure how you deal with tests. I could not find tests for e.g. stride to I tried to be non-intrusive. But let me know if you want otherwise.

Copy link
Owner

@wjakob wjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick review. Two further requests:

  • Please at least reference those functions somewhere from a C++ test case.
  • They will still need to be mentioned in the API documentation docs/api_extra.rst

@wjakob
Copy link
Owner

wjakob commented Mar 31, 2023

The changed code looks good, but please note the request above regarding documentation + test coverage.

@wjakob
Copy link
Owner

wjakob commented Apr 1, 2023

Thanks!

@wjakob wjakob merged commit a727642 into wjakob:master Apr 1, 2023
@wjakob wjakob changed the title NumPy: adding size, shape_ptr, stride_ptr nb::ndarray: adding size, shape_ptr, stride_ptr members Apr 1, 2023
@tdegeus tdegeus deleted the size branch April 1, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants