Add type caster for string_view. #68
Merged
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @qnzhou — this looks great, but it is missing a testcase. Could you add one for both directions of the conversion? |
wjakob
reviewed
Sep 28, 2022
| assert t.identity_string("orange") == "orange" | ||
| assert t.identity_string("橘子") == "橘子" | ||
| assert t.identity_string("ส้ม") == "ส้ม" | ||
| assert t.identity_string("البرتقالي") == "البرتقالي" |
There was a problem hiding this comment.
Is there something funny going on with parentheses here?
There was a problem hiding this comment.
I don't quite understand. Is there anything wrong with the parentheses?
There was a problem hiding this comment.
Could it be a rendering issue? At least on the GitHub web interface, I don't see a closing parenthesis after the arabic strings.
There was a problem hiding this comment.
Fascinating. That code passes the test suite, so I will believe you ;).
wjakob
reviewed
Sep 28, 2022
| assert t.identity_string_view("orange") == "orange" | ||
| assert t.identity_string_view("橘子") == "橘子" | ||
| assert t.identity_string_view("ส้ม") == "ส้ม" | ||
| assert t.identity_string_view("البرتقالي") == "البرتقالي" |
|
This is what it looks like on my screen.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small update to automatically type cast
std::string_view.