Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add std::map and std::unordered_map type casters #73

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Add std::map and std::unordered_map type casters #73

merged 2 commits into from
Oct 12, 2022
+199 −0

Conversation

mferencevic
Copy link
Contributor

I've implemented a std::map and std::unordered_map type caster that converts to/from a Python dict. I've extracted the common logic into detail/nb_dict.h similar to the current implementation for std::list and std::vector in detail/nb_list.h.

@wjakob
Copy link
Owner

wjakob commented Oct 3, 2022

It looks great! I left a few minor comments.

@mferencevic
Copy link
Contributor Author

Thanks! I've fixed the issues you've found.

@wjakob
Copy link
Owner

wjakob commented Oct 3, 2022

Thanks!

@wjakob wjakob merged commit e42818c into wjakob:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjakob wjakob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mferencevic @wjakob