Watch mode (--interval) #41
Merged
+38
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rebased and squashed commit from dron's `loop` branch. Related PR: #30
Stonesjtu
reviewed
Jun 14, 2018
gpustat/core.py
Outdated
| @@ -379,6 +379,8 @@ def print_formatted(self, fp=sys.stdout, force_color=False, no_color=False, | |||
| show_cmd=False, show_user=False, show_pid=False, | |||
| show_power=None, gpuname_width=16, | |||
| show_header=True, | |||
| eol_char='\n', | |||
There was a problem hiding this comment.
Is this eol character portable for OS other than POSIX? I think windows use '\n\r' or '\r\n'. However, it doesn't matter if we target on only POSIX systems.
There was a problem hiding this comment.
os.linesep can be a better choice of default parameter.
There was a problem hiding this comment.
Yeah, it was previously just '\n'. I would say POSIX systems are just targetted, but totally fine with using os.linesep.
Stonesjtu
reviewed
Jun 14, 2018
gpustat/__main__.py
Outdated
| @@ -66,7 +71,27 @@ def main(*argv): | |||
| version=('gpustat %s' % __version__)) | |||
| args = parser.parse_args(argv[1:]) | |||
|
|
|||
| print_gpustat(**vars(args)) | |||
| if args.interval > 0: | |||
There was a problem hiding this comment.
It should be better to have a minimal interval of 0.1 sec like watch.
|
The doc needs an update too. |
|
LGTM, but the README needs an update to show-off new option. |
wookayin
added a commit
that referenced
this pull request
Aug 18, 2018
Watch mode (--interval) support Conflicts: gpustat/__main__.py
|
Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-i/--intervalto support built-in watch feature.Based on @drons 's PR #30.