Skip to content
This repository has been archived by the owner on Nov 7, 2021. It is now read-only.

PstlAdr field is optional is the Dbtr section for BankCreditTransfer … #28

Merged

Conversation

celinederoland
Copy link

…transactions.

I add a new 'EmptyPostalAddress' implementation which doesn't generate any DOMElement
I test the constructor of BankCreditTransfer with an instance of this implementation
I add a transaction of 1300 CHF in the CustomerCreditTransferTest, and check that the generated xml file is ever valid (the headers CtrlSum and NbOfTxs change in consequence)

…transactions.

I add a new 'EmptyPostalAddress' implementation which doesn't generate any DOMElement
I test the constructor of BankCreditTransfer with an instance of this implementation
I add a transaction of 1300 CHF in the CustomerCreditTransferTest, and check that the generated xml file is ever valid (the headers CtrlSum and NbOfTxs change in consequence)
@z38 z38 merged commit b968153 into z38:master Jul 16, 2018
@z38
Copy link
Owner

z38 commented Jul 16, 2018

Thank you for your contribution! I'm sorry it took me so long to review your changes.
To improve the DX a bit, I took the liberty to replace EmptyPostalAddress with null.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants