[Fix] Process sources only when source yaml is available #118
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@z3z1ma please review when you get a chance |
|
was running in to this same problem and made the same fix in my pipx env. still not entirely sure what the problem is. i would run |
|
This makes sense to me. I was partial to 'homogenizing' all the files (guaranteeing same structure and keys) but am not particular anymore. There was a prior commit I think that made this error possible. |
|
This PR is published? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
When running
refactor, process any changes to source yaml only when it exists/is defined. It is quite common for intermediate and mart models to not have a source file defined.How to reproduce
Run
refactoron a folder that contains schema yaml file but doesn't contain the source yaml fileAdditional context
Should fix #115