Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to support dbt-core 1.6 and above #151

Merged
merged 2 commits into from
May 17, 2024

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented May 16, 2024

Currently, dbt-osmosis supports a very wide range of dbt-core versions. As a result, there is code that diverges depending on the version of dbt-core, resulting in complexity and test case omissions. And Support level and end date for dbt 1.5 and below is End of Life.

This pull request explicitly limits the supported dbt-core versions so that dbt-osmosis can keep up with new dbt-core versions as they become available and remain highly maintainable.

@syou6162 syou6162 force-pushed the feature/drop_dbt_core_1.5_or_below branch from e5094b2 to ade9821 Compare May 16, 2024 14:28
@syou6162 syou6162 changed the title WIP: Modify to support dbt-core 1.6 and above Modify to support dbt-core 1.6 and above May 16, 2024
@syou6162 syou6162 marked this pull request as ready for review May 16, 2024 14:42
@syou6162
Copy link
Contributor Author

@z3z1ma As I had received prior feedback in the comments, I have prepared a pull request with a modification to explicitly remove support for versions below 1.5 of dbt-core. Could you review it?

@z3z1ma
Copy link
Owner

z3z1ma commented May 17, 2024

LGTM, thanks so much @syou6162 🙇

@z3z1ma z3z1ma merged commit eadaff3 into z3z1ma:main May 17, 2024
3 checks passed
@syou6162 syou6162 deleted the feature/drop_dbt_core_1.5_or_below branch May 17, 2024 05:47
This was referenced May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants