-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with pytorch version #53
Comments
Hi @ibrahim-601, Thank you for reporting. This is an interesting finding. Could you reproduce the result using lcnn/lcnn/models/line_vectorizer.py Line 162 in 88f281a
|
Hi @zhou13, thank you very much for replying. The above result is produced with
at lcnn/lcnn/models/line_vectorizer.py Line 162 in 88f281a
The values of jmap and joff in PyTorch 1.4.0 and PyTorch 1.8.1 are the same.I have uploaded the original image and some test results along with the JSON files here. |
In PyTorch 1.4.x (index/128) at https://github.com/zhou13/lcnn/blob/88f281ab5421d51a62f1f84f97fea05afbf0c8d8/lcnn/models/line_vectorizer.py#L174 outputs integer values but in PyTorch 1.8.x it outputs float values. Updating it with (index//128) outputs integer values in both PyTorch versions and solves zhou13#53 (comment).
I tried following the instructions on the repository. Pytorch 1.8.1 is installed with the instructions. But with that environment, the right points of lines get a little bit downward. But if I try the same with PyTorch 1.4.0 there is no issue. Can you please explain why is this happening? Or can you update the instructions for the correct PyTorch version? I have attached both outputs. The first one is with PyTorch 1.4.0 and the second one is with PyTorch 1.8.1.
PyTorch 1.4.0 sample:
PyTorch 1.8.1 sample:
The text was updated successfully, but these errors were encountered: