Amazon: Update for new layout and updating tests #2942
Merged
+32
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajamtli
commented
Dec 6, 2022
- Added extraction of abstractNote from book description expander
- Rearranged matching for detail bullet list, assuming newer design is most likely to be encountered
- Supporting new design of bullet list
- Updated tests to match current content with the following exceptions:
- Removed wishlist test since the list does not exist
- 'Adaptation' language list is not sorted from Amazon and test will randomly fail
- 'audioRecording' - unable to test, Scaffold browser not supported
- Added extraction of abstractNote from book description expander
- Rearranged matching for detail bullet list, assuming newer design is
most likely to be encountered
- Supporting new design of bullet list
- Updated tests to match current content with the following exceptions:
- Removed wishlist test since the list does not exist
- 'Adaptation' language list is not sorted from Amazon and test will
randomly fail
- 'audioRecording' - unable to test, Scaffold browser not supported
AbeJellinek
requested changes
Dec 8, 2022
| @@ -354,12 +348,23 @@ function scrape(doc, url) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (!els.length) { | |||
There was a problem hiding this comment.
Why does this need to be moved down?
There was a problem hiding this comment.
Because movies still use an information table that will match the expression. However this is just a subset of the information and we want to extract from the detailBullets_feature_div for movies as well since this contains all the information elements we want to capture.
Co-authored-by: Abe Jellinek <jellinek@berkeley.edu>
Co-authored-by: Abe Jellinek <jellinek@berkeley.edu>
|
The tests already cover the design changes by checking that the details and the abstract note is correctly picked up. |
|
OK, please update |
|
Timestamp updated. Thank you for your help and guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.