DOI: Pull DOIs from URL #2967
Merged
DOI: Pull DOIs from URL #2967
+139
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If only the URL contains a DOI (or the URL contains a DOI and the body contains only that same DOI), we now detect a single `journalArticle` item and don't show the Select Items dialog. Also optimized the page-scraping code a little bit by replacing Array#includes() calls (O(n^2) overall) with Set#has() (O(n) overall).
dstillman
reviewed
Jan 24, 2023
|
We can add a test for single-item detection (DOI in URL and no other DOIs on the page) if we can find an example, but I really could not. Pages with a DOI in the URL almost always contain another DOI somewhere. |
I can find you an example that has the same DOI on the page but no others, would that do? |
|
Yeah, that would. |
|
Thanks! With the other fix included in that last commit, we now have two tests for single items. |
zoe-translates
pushed a commit
to zoe-translates/translators
that referenced
this pull request
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only the URL contains a DOI (or the URL contains a DOI and the body contains only that same DOI), we now detect a single
journalArticleitem and don't show the Select Items dialog.Also optimized the page-scraping code a little bit by replacing
Array#includes()calls (O(n^2) overall) withSet#has()(O(n) overall).Fixes #2964