Page MenuHomePhabricator
Create Task
Maniphest T145462

Provide auto-citations based on ISBNs in Wikimedia production
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
Mvolz
Authored By
Jdforrester-WMF
Sep 12 2016, 9:24 PM
Tags
Referenced Files
None
Subscribers
Aklapper
• Elitre
gerritbot
Jdforrester-WMF
Mvolz
• Ocaasi_WMF
PKM
View All 11 Subscribers
Tokens
"Barnstar" token, awarded by RandomDSdevel."Like" token, awarded by Liuxinyu970226."Party Time" token, awarded by Elitre."Barnstar" token, awarded by Johan."Like" token, awarded by Trizek-WMF.

Description

Top-level task.

Details

SubjectRepoBranchLines +/-
i18n: Tell users they can use ISBNsmediawiki/extensions/Citoidwmf/1.30.0-wmf.1+2 -2
i18n: Tell users they can use ISBNsmediawiki/extensions/Citoidwmf/1.29.0-wmf.21+2 -2
i18n: Tell users they can use ISBNsmediawiki/extensions/Citoidmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 12 2016, 9:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2016, 9:24 PM
Jdforrester-WMF created subtask T145463: Credit the source of the ISBN data in Citoid Extension.Sep 12 2016, 9:26 PM
Jdforrester-WMF added a subtask: T1084: Add ISBN as look-up option to the citoid service.Sep 12 2016, 9:29 PM
Jdforrester-WMF created subtask T145467: Where returning data from WorldCat, include the OCLC#.Sep 12 2016, 9:38 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added subscribers: Quiddity, • Elitre, • Whatamidoing-WMF, Trizek-WMF.Sep 12 2016, 9:54 PM
Trizek-WMF awarded a token.Sep 13 2016, 1:31 PM
Trizek-WMF added subscribers: VIGNERON, Envlh.
Johan moved this task from To Triage to Not ready to announce on the User-notice board.Sep 14 2016, 8:42 AM
Mvolz moved this task from Backlog to IO Tasks on the Citoid board.Sep 19 2016, 2:53 PM
Jdforrester-WMF closed subtask T145467: Where returning data from WorldCat, include the OCLC# as Resolved.Oct 3 2016, 9:58 PM
• mobrovac reopened subtask T145467: Where returning data from WorldCat, include the OCLC# as Open.Oct 3 2016, 10:04 PM
• mobrovac closed subtask T145467: Where returning data from WorldCat, include the OCLC# as Resolved.Oct 6 2016, 1:57 PM
Mvolz moved this task from IO Tasks to Service on the Citoid board.Oct 28 2016, 3:02 PM
• mobrovac changed the status of subtask T1084: Add ISBN as look-up option to the citoid service from Stalled to Open.Dec 2 2016, 5:47 PM
Jdforrester-WMF mentioned this in T1084: Add ISBN as look-up option to the citoid service.Dec 7 2016, 3:59 PM
Jdforrester-WMF closed subtask T1084: Add ISBN as look-up option to the citoid service as Resolved.
Jdforrester-WMF added a comment.Dec 7 2016, 4:04 PM

Things left to do, AFAICT:

  • T145463: Credit the source of the ISBN data in Citoid Extension – is this just adding an if statement and a new i18n message?
  • Update citoid-citefromiddialog-search-label
  • Adjust enwiki templatedata/citoid maps to make sure the ISBN value gets back into the template
  • Confirm with OCLC that they're happy.
  • Announce in Tech/News and VPs.

Did I miss anything?

• Elitre added a comment.Dec 7 2016, 4:10 PM

(Does #3 means that other wikis will have to copy that fix? If so, it needs to be communicated in the announcement.)

Jdforrester-WMF added a comment.Dec 7 2016, 4:12 PM
In T145462#2854275, @Elitre wrote:

(Does #3 means that other wikis will have to copy that fix? If so, it needs to be communicated in the announcement.)

Yeah, we'll also need to update documentation.

Mvolz subscribed.Dec 7 2016, 4:16 PM

Pretty much all of the templates already have an ISBN field in the
templatedata. It's the OCLC number that they may not have.

Mvolz added a comment.Dec 7 2016, 7:20 PM

I will add the OCLC # in as I am already slogging through all of the TD
everywhere anyway :). Tracking in: T114515

Mvolz added a subtask: Restricted Task.Jan 19 2017, 12:50 PM
Mvolz created subtask T155729: Possibly add ISBN look-up to reftoolbar2.0.Jan 19 2017, 1:00 PM
Mvolz created subtask T155730: Prevent WorldCat sourced citations from being cached in citoid's restbase endpoint any longer than 72 hours.Jan 19 2017, 1:05 PM
Mvolz created subtask T155731: Possibly deny X-domain access to restbase instance in citoid?.Jan 19 2017, 1:15 PM
Envlh unsubscribed.Jan 19 2017, 1:56 PM
Mvolz closed subtask T155730: Prevent WorldCat sourced citations from being cached in citoid's restbase endpoint any longer than 72 hours as Invalid.Jan 19 2017, 4:20 PM
Jdforrester-WMF removed a subtask: T155729: Possibly add ISBN look-up to reftoolbar2.0.Jan 19 2017, 10:45 PM
Mvolz closed subtask T155731: Possibly deny X-domain access to restbase instance in citoid? as Declined.Jan 28 2017, 1:31 PM
Jdforrester-WMF added a subtask: T115248: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search.Feb 28 2017, 8:36 PM
• Ocaasi_WMF subscribed.Feb 28 2017, 8:40 PM
• Ocaasi_WMF unsubscribed.
• Ocaasi_WMF subscribed.
gerritbot subscribed.Feb 28 2017, 8:52 PM

Change 340360 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/Citoid] i18n: Tell users they can use ISBNs

https://gerrit.wikimedia.org/r/340360

gerritbot added a project: Patch-For-Review.Feb 28 2017, 8:52 PM
Jdforrester-WMF closed subtask T145463: Credit the source of the ISBN data in Citoid Extension as Resolved.Feb 28 2017, 8:58 PM
Jdforrester-WMF removed a subtask: T115248: Strings of digits currently only search for PMIDs; Add multiple results and include OCLC and PMC in the search.
Jdforrester-WMF closed subtask Restricted Task as Resolved.May 10 2017, 5:48 PM
gerritbot added a comment.May 10 2017, 8:43 PM

Change 340360 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] i18n: Tell users they can use ISBNs

https://gerrit.wikimedia.org/r/340360

gerritbot added a comment.May 10 2017, 8:45 PM

Change 353176 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Citoid@wmf/1.30.0-wmf.1] i18n: Tell users they can use ISBNs

https://gerrit.wikimedia.org/r/353176

gerritbot added a comment.May 10 2017, 8:45 PM

Change 353177 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Citoid@wmf/1.29.0-wmf.21] i18n: Tell users they can use ISBNs

https://gerrit.wikimedia.org/r/353177

Jdforrester-WMF assigned this task to Mvolz.May 10 2017, 8:54 PM
Jdforrester-WMF moved this task from Not ready to announce to Announce in next Tech/News on the User-notice board.

i18n going out in this afternoon's SWAT.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 10 2017, 9:00 PM
gerritbot added a comment.May 10 2017, 11:10 PM

Change 353177 merged by jenkins-bot:
[mediawiki/extensions/Citoid@wmf/1.29.0-wmf.21] i18n: Tell users they can use ISBNs

https://gerrit.wikimedia.org/r/353177

gerritbot added a comment.May 10 2017, 11:12 PM

Change 353176 merged by jenkins-bot:
[mediawiki/extensions/Citoid@wmf/1.30.0-wmf.1] i18n: Tell users they can use ISBNs

https://gerrit.wikimedia.org/r/353176

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)); removed MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 11 2017, 12:00 AM
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.May 11 2017, 10:07 PM
Jdforrester-WMF closed this task as Resolved.May 12 2017, 12:03 AM
Jdforrester-WMF removed a project: Patch-For-Review.

Yay.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 12 2017, 12:03 AM
Johan awarded a token.May 12 2017, 12:12 AM
• Elitre awarded a token.May 12 2017, 7:50 AM
Liuxinyu970226 awarded a token.May 16 2017, 4:28 AM
RandomDSdevel awarded a token.May 16 2017, 11:10 PM
RandomDSdevel rescinded a token.
RandomDSdevel awarded a token.
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.May 18 2017, 9:13 PM
PKM subscribed.EditedMay 25 2017, 8:52 PM

I am consistently seeing an error in ISBN lookup for items published by museums. The museum is being imported as the author, broken into Last and first (last=Art, first= Metropolitan Museum of).

Examples from May 24 and May 25:

ISBN 978-3925801228 (correct author is Anna A Ierusalimskaja . I got last=(Russia)|first=Gosudarstvennyĭ Ėrmitazh|last2=Nationalmuseum.|first2=Bayerisches. Correct info at https://www.amazon.de/Gr%C3%A4ber-Moscevaja-Balka-Fr%C3%BChmittelalterliche-nordkaukasischen/dp/3925801227)

ISBN 9780888540461 (correct author is Dorothy K. Burnham. I got last=Museum, first=Royal Ontario. Info here: https://books.google.com/books?id=-DPdPAAACAAJ

now a bug T166445

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits