Page MenuHomePhabricator
Create Task
Maniphest T242769

Wikibase UI API calls should request a specific errorformat and uselang
Closed, ResolvedPublic
Actions

Description

Problem:

While investigating T170424 I deep dove (description at T170424#5802420) and found that most of our UI calls to the API are probably using the backward compatibility layer.
In order to solve T170424 and get more relevant and translated errors to our users we should specify an errorformat so that the newer code for error output in the MediaWiki API is used.

Example:

New format : https://test.wikidata.org/w/api.php?action=wbparsevalue&format=json&parser=globecoordinate&values=%1F36&options=%7B%22lang%22%3A%22de%22%7D&errorformat=plaintext&uselang=de

Old Format: https://test.wikidata.org/w/api.php?action=wbparsevalue&format=json&parser=globecoordinate&values=%1F36&options=%7B%22lang%22%3A%22de%22%7D&uselang=de

Look at the first error to appear in the JSON output

Acceptance criteria:

  • All Wikidata / WMDE owned UI code calling APIs should specify an errorformat and a uselang parameter

Details

SubjectRepoBranchLines +/-
Update data-values/value-view submodulemediawiki/extensions/Wikibasemaster+1 -1
Add errorformat parameter to wikibase API requestmediawiki/extensions/Wikibasemaster+19 -0
Add errorformat parameter to wikibase API requestmediawiki/extensions/WikibaseLexememaster+27 -10
Add errorformat parameter to wikibase API requestdata-values/value-viewmaster+1 -0
Use message parameters when creating RepoApiErrorwikibase/javascript-apimaster+214 -179
Add errorformat parameter to wikibase API requestsmediawiki/extensions/Wikibasemaster+2 -2
Add errorformat parameter to wikibase API requestswikibase/javascript-apimaster+259 -54
Change wbparsevalue API call to request plaintext errorformatwikibase/javascript-apimaster+33 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 14 2020, 5:01 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJan 14 2020, 5:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore triaged this task as Medium priority.Jan 14 2020, 5:02 PM
Addshore added a parent task: T170424: In Wikidata value entering boxes "Malformed value", date precision values, and other elements cannot be translated.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore added a project: Technical-Debt.
Addshore moved this task from incoming to consider for next sprint on the Wikidata board.Jan 14 2020, 5:04 PM
Michael subscribed.Jan 14 2020, 5:15 PM
WMDE-leszek subscribed.Jan 14 2020, 5:17 PM
Lucas_Werkmeister_WMDE subscribed.EditedJan 14 2020, 5:42 PM

Just uselang should be fine IMHO, any reason for adding errorlang?

Addshore added a comment.Jan 14 2020, 8:07 PM
In T242769#5802663, @Lucas_Werkmeister_WMDE wrote:

Just uselang should be fine IMHO, any reason for adding errorlang?

Uselang should indeed be fine :).
I doubt there are any cases where the default en behaviour of the general MediaWiki language in the API processing is needed by the UI... But in theroy could be possible!

Addshore added a comment.Jan 14 2020, 8:11 PM

Infact, checking back 1 more time uselang is not needed.
Simply passing errorformat= is enough and then the user language is already automatically used without needing to be passed.

Addshore renamed this task from Wikidata UI API calls should request a specific errorformat & uselang / errorlang to Wikidata UI API calls should request a specific errorformat.Jan 14 2020, 8:12 PM
Addshore updated the task description. (Show Details)
Addshore renamed this task from Wikidata UI API calls should request a specific errorformat to Wikibase UI API calls should request a specific errorformat.Jan 14 2020, 8:56 PM
Lucas_Werkmeister_WMDE added a comment.Jan 15 2020, 10:11 AM

Simply passing errorformat= is enough and then the user language is already automatically used without needing to be passed.

…unless the user loaded the current page with a ?uselang parameter different from what’s stored in the session – at least I assume that’s why we already pass uselang to our API requests?

• Pablo-WMDE subscribed.Jan 15 2020, 12:48 PM
Addshore added a comment.Jan 27 2020, 3:24 PM
In T242769#5804554, @Lucas_Werkmeister_WMDE wrote:

Simply passing errorformat= is enough and then the user language is already automatically used without needing to be passed.

…unless the user loaded the current page with a ?uselang parameter different from what’s stored in the session – at least I assume that’s why we already pass uselang to our API requests?

Sounds like that might be the reasoning

Addshore moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.Jan 27 2020, 3:24 PM
Addshore moved this task from Ready to pick up to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Jan 27 2020, 3:40 PM
Addshore mentioned this in T243660: Error message Wikibase-validator-url-scheme-missing is shown in content instead of user lanuage.Jan 27 2020, 4:40 PM
Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 29 2020, 3:00 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Silvan_WMDE claimed this task.Feb 4 2020, 10:10 AM
Silvan_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Silvan_WMDE updated the task description. (Show Details)Feb 4 2020, 1:16 PM
gerritbot added a comment.Feb 4 2020, 1:58 PM

Change 570053 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[wikibase/javascript-api@master] Change wbparsevalue API call to request plaintext errorformat

https://gerrit.wikimedia.org/r/570053

gerritbot added a project: Patch-For-Review.Feb 4 2020, 1:58 PM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 4 2020, 4:49 PM
gerritbot added a comment.Feb 4 2020, 5:01 PM

Change 570053 merged by jenkins-bot:
[wikibase/javascript-api@master] Change wbparsevalue API call to request plaintext errorformat

https://gerrit.wikimedia.org/r/570053

Maintenance_bot removed a project: Patch-For-Review.Feb 4 2020, 5:11 PM
Jakob_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 5 2020, 10:17 AM
gerritbot added a comment.Feb 6 2020, 12:14 PM

Change 570620 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[wikibase/javascript-api@master] Add errorformat parameter to wikibase API requests

https://gerrit.wikimedia.org/r/570620

gerritbot added a project: Patch-For-Review.Feb 6 2020, 12:14 PM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 6 2020, 12:21 PM
Silvan_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 7 2020, 2:22 PM
gerritbot added a comment.Feb 7 2020, 3:31 PM

Change 570907 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/Wikibase@master] Add errorformat parameter to wikibase API requests

https://gerrit.wikimedia.org/r/570907

gerritbot added a comment.Feb 7 2020, 3:35 PM

Change 570620 merged by jenkins-bot:
[wikibase/javascript-api@master] Add errorformat parameter to wikibase API requests

https://gerrit.wikimedia.org/r/570620

Silvan_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 7 2020, 3:50 PM
gerritbot added a comment.Feb 10 2020, 11:24 AM

Change 570907 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add errorformat parameter to wikibase API requests

https://gerrit.wikimedia.org/r/570907

Silvan_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 10 2020, 11:26 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 10 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 12:11 PM
Lucas_Werkmeister_WMDE mentioned this in T245245: Message Wikibase-error-ui-no-external-page shows literal $1 and $2 instead of values.Feb 14 2020, 6:39 PM
gerritbot added a comment.Feb 18 2020, 12:30 PM

Change 572662 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[wikibase/javascript-api@master] Use message parameters when creating RepoApiError

https://gerrit.wikimedia.org/r/572662

gerritbot added a project: Patch-For-Review.Feb 18 2020, 12:31 PM
gerritbot added a comment.Feb 19 2020, 1:10 PM

Change 572662 merged by jenkins-bot:
[wikibase/javascript-api@master] Use message parameters when creating RepoApiError

https://gerrit.wikimedia.org/r/572662

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 1:10 PM
Silvan_WMDE renamed this task from Wikibase UI API calls should request a specific errorformat to Wikibase UI API calls should request a specific errorformat and uselang.Feb 20 2020, 8:48 AM
Silvan_WMDE updated the task description. (Show Details)
Silvan_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Silvan_WMDE added a comment.EditedFeb 20 2020, 9:57 AM

additional changes needed:

gerritbot added a comment.Feb 25 2020, 10:01 AM

Change 574708 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[data-values/value-view@master] Add errorformat parameter to wikibase API request

https://gerrit.wikimedia.org/r/574708

gerritbot added a project: Patch-For-Review.Feb 25 2020, 10:01 AM
gerritbot added a comment.Feb 25 2020, 10:38 AM

Change 574712 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Add errorformat parameter to wikibase API request

https://gerrit.wikimedia.org/r/574712

gerritbot added a comment.Feb 25 2020, 12:29 PM

Change 574730 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/Wikibase@master] Add errorformat parameter to wikibase API request

https://gerrit.wikimedia.org/r/574730

Silvan_WMDE added a comment.Feb 25 2020, 12:34 PM

The three related patch sets are needed, as three different projects are affected:

After the first one (574708) has been merged, an additional update of the data-values/value-view submodule will be needed in Wikibase, to activate the changes.

Silvan_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 25 2020, 12:35 PM
gerritbot added a comment.Feb 25 2020, 12:56 PM

Change 574708 merged by jenkins-bot:
[data-values/value-view@master] Add errorformat parameter to wikibase API request

https://gerrit.wikimedia.org/r/574708

gerritbot added a comment.Feb 25 2020, 1:19 PM

Change 574730 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add errorformat parameter to wikibase API request

https://gerrit.wikimedia.org/r/574730

gerritbot added a comment.Feb 25 2020, 1:27 PM

Change 574712 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add errorformat parameter to wikibase API request

https://gerrit.wikimedia.org/r/574712

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 25 2020, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2020, 2:11 PM
gerritbot added a comment.Feb 25 2020, 2:39 PM

Change 574759 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/Wikibase@master] Update data-values/value-view submodule

https://gerrit.wikimedia.org/r/574759

gerritbot added a project: Patch-For-Review.Feb 25 2020, 2:39 PM
gerritbot added a comment.Feb 25 2020, 9:00 PM

Change 574759 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update data-values/value-view submodule

https://gerrit.wikimedia.org/r/574759

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2020, 9:10 PM
• 1sollo25 moved this task from consider for next sprint to incoming on the Wikidata board.Feb 26 2020, 6:46 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 26 2020, 7:15 AM
Silvan_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 26 2020, 8:15 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 26 2020, 4:02 PM
Addshore mentioned this in T247690: Detail of error message is no longer shown in Wikidata edit interface.Apr 28 2020, 12:31 PM
Addshore closed this task as Resolved.May 4 2020, 1:12 PM

Resolving this as it is done, but also noting that T247690 has been created which might relate to the code that was touched in this ticket.

Jakob_WMDE mentioned this in T260869: Wikidata sitelink save, shows error message twice..Sep 4 2020, 3:34 PM
Addshore mentioned this in T170424: In Wikidata value entering boxes "Malformed value", date precision values, and other elements cannot be translated.Dec 1 2020, 9:38 AM
Lydia_Pintscher mentioned this in T269102: Localized precision in time and geocoordinate inputs.Dec 1 2020, 11:30 AM
Lucas_Werkmeister_WMDE mentioned this in T304945: Remove custom error responses (localization, several errors) from Wikibase APIs.Mar 29 2022, 1:28 PM
Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 29 2022, 2:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits