Special:SecurePoll/edit doesn't always load existing custom message labels
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DannyS712
	Oct 2 2020, 10:08 PM

Description

See, eg, https://meta.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/edit/17
Steps to reproduce:
Create a securepoll with:

poll type: Range voting (histogram range)
question: Question text
minimum score: -1
maximum score: 1
default score: 0
Use custom messages for column labels: enabled
custom messages: put anything for -1, 0, and 1

Save the poll, then go back and edit it

Expected result:
Existing custom messages for column labels are preloaded

Actual result:
Only the custom messages for -1 and 0 are loaded, the message for 1 is blank

I tried this again with -2, -1, 0, 1, and 2, and only 1 and 2 had there messages fail to preload. Perhaps its because they are positive?
The messages are still shown at the voting page though (https://meta.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/vote/17)

Details

	Subject	Repo	Branch	Lines +/-
	Fix signed/unsigned confusion in create page	mediawiki/extensions/SecurePoll	master	+20 -7
	Fix broken custom labels due to lack of JS number casting	mediawiki/extensions/SecurePoll	master	+2 -2

Customize query in gerrit

Event Timeline

DannyS712 created this task.Oct 2 2020, 10:08 PM

Restricted Application added projects: User-DannyS712, Platform Engineering. · View Herald TranscriptOct 2 2020, 10:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 changed the subtype of this task from "Task" to "Bug Report".Oct 2 2020, 10:08 PM

DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.

DannyS712 updated the task description. (Show Details)Oct 2 2020, 10:12 PM

BPirkle triaged this task as Medium priority.Oct 6 2020, 8:55 PM

BPirkle edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

BPirkle moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

Change 644362 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/SecurePoll@master] [WIP] Fix broken custom labels due to lack of JS number casting

https://gerrit.wikimedia.org/r/644362

gerritbot added a project: Patch-For-Review.Nov 30 2020, 11:46 PM

Change 644374 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/extensions/SecurePoll@master] Fix signed/unsigned confusion in create page

https://gerrit.wikimedia.org/r/644374

Change 644362 abandoned by Aaron Schulz:
[mediawiki/extensions/SecurePoll@master] Fix broken custom labels due to lack of JS number casting

Reason:
Superseded

https://gerrit.wikimedia.org/r/644362

Change 644374 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Fix signed/unsigned confusion in create page

https://gerrit.wikimedia.org/r/644374

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 1 2020, 7:00 PM

• Clarakosi assigned this task to tstarling.Dec 2 2020, 4:32 PM

• Clarakosi moved this task from Later to Done on the Platform Team Workboards (Clinic Duty Team) board.

Evaluation:

Already has a merged bugfix. May need validation

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 4:31 PM

@tstarling: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

I think this was fixed. Cannot reproduce.

Special:SecurePoll/edit doesn't always load existing custom message labelsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Special:SecurePoll/edit doesn't always load existing custom message labels
Closed, ResolvedPublicBUG REPORT
Actions