Page MenuHomePhabricator

Stop showing IP warning on when setting label, description and aliases for EntitySchema for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic

Description

Problem:
We are showing warnings when setting label, description and aliases for EntitySchema and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.

Example

image.png (604×1 px, 92 KB)

In the example above when setting label, description and aliases for EntitySchemas only the IP warning should be removed.
i.e. "Warning: You are not logged in. Your IP address will be publicly visible if you make any edits."

This should only be removed only when IP masking is enabled.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases

BDD
GIVEN a user that isn't logged in
WHEN setting label, description and aliases for EntitySchema
AND IP Masking is enabled
THEN do not show the IP leak warning

Acceptance criteria:

  • IP leak warning isn't shown when setting label, description and aliases for EntitySchemas when IP Masking is enabled

Event Timeline

Change 987130 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] Remove IP address warning for set label when TempUser enabled

https://gerrit.wikimedia.org/r/987130

Change 987130 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Remove IP address warning for set label when TempUser enabled

https://gerrit.wikimedia.org/r/987130

Thanks so much, this looks good to me