Upgrade from node16 to node20 #443
Conversation
e55390f
to
fefa09a
Compare
|
CI is currently failing, but the tests all passed. One of our tests generates an error and it seems like the Actions runner is picking up on that and reporting the step as failed?
|
fefa09a
to
50ddf9b
Compare
50ddf9b
to
1d917af
Compare
|
Is the underlying actions issue mentioned here related to the CI failures? |
The original issue was but I think node 20 has shipped on Actions runners. Now I see a new error around a missing GitHub token that I can take care of in a bit. |
|
As we near the deadline in Spring 2024, this action has begun generating deprecation warnings. Are there any obstacles in the migration process? I anticipate this becoming a prominent topic soon, as more individuals express frustration with these warnings. |
cb05b4e
to
beeeb28
Compare
Nope just got busy. We're going to release this as a major version update since it breaks compatibility with older GitHub Enterprise Server versions that don't ship with Node20. I'll create a minor release for whatever changes are on main first, though. |
|
Would really appreciate a release /w node20 support soon. Most of the actions are already migrated.... |
|
@Nishnha I'm unclear what's the next step here? Do we need a minor release to catchup to Should we land any of the other outstanding PR's first? I can take a look and make judgement calls but assume you've already looked at this? |
beeeb28
to
36ef1c7
Compare
Co-authored-by: Paul <[email protected]>
1021: chore(deps): update dependabot/fetch-metadata action to v2 r=korthout a=renovate[bot] [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [dependabot/fetch-metadata](https://togithub.com/dependabot/fetch-metadata) | action | major | `v1.7.0` -> `v2.0.0` | --- ### Release Notes <details> <summary>dependabot/fetch-metadata (dependabot/fetch-metadata)</summary> ### [`v2.0.0`](https://togithub.com/dependabot/fetch-metadata/releases/tag/v2.0.0): - Switch to `node20` [Compare Source](https://togithub.com/dependabot/fetch-metadata/compare/v1.7.0...v2.0.0) #### What's Changed - Upgrade from node16 to node20 by [`@​Nishnha](https://togithub.com/Nishnha)` in [https://github.com/dependabot/fetch-metadata/pull/443](https://togithub.com/dependabot/fetch-metadata/pull/443) 👈 this is a potentially breaking change for some workflows - `v2` is the new tracking tag by [`@​jeffwidman](https://togithub.com/jeffwidman)` in [https://github.com/dependabot/fetch-metadata/pull/506](https://togithub.com/dependabot/fetch-metadata/pull/506) - v2.0.0 by [`@​fetch-metadata-action-automation](https://togithub.com/fetch-metadata-action-automation)` in [https://github.com/dependabot/fetch-metadata/pull/508](https://togithub.com/dependabot/fetch-metadata/pull/508) **Full Changelog**: dependabot/fetch-metadata@v1.7.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/zeebe-io/zeebe-cluster-testbench). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Node16 is now EOL. The next LTS release is node18 which has support until 2025, but node20 has support until 2026.
https://nodejs.dev/en/about/releases/