-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commiter_date: fix github api request fallback #478
Conversation
I think it's same API we are using |
Yes I was looking to have types handled so response schema matches. |
dd5bc23
to
6c97e81
Compare
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
6c97e81
to
e01ddd3
Compare
@trim21 I'm going to get this one in if you don't mind. I prefer to avoid raw request. LGTY? |
it's not raw request now, it will have typing after my PR |
Still this is a generic request and using the specific method provided by the Octokit REST API client for fetching a commit provides better type safety and autocompletion |
ok
CrazyMax ***@***.***> 于2024年11月20日周三 00:52写道:
… it's not raw request now, it will have typing after my PR
Still this is a generic request and using the specific method provided by
the Octokit REST API client for fetching a commit provides better type
safety and autocompletion
—
Reply to this email directly, view it on GitHub
<#478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHNB3ZGR24XRBV34BY4IKL2BNUFZAVCNFSM6AAAAABSCO4CHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWGI2DKNJYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fixes #476
cc @trim21