-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] [browser] Remove duplicated marshaling of return value for JSExport #92886
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #92403 to release/8.0 /cc @maraf Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #92403 to release/8.0 /cc @maraf Customer ImpactDuplicated marshalling of return value has extra allocations that may leak and has performance impact TestingManually observed generated code. Automated tests that the generated code works. Automated tests (for checking duplicated return value marshalling) tracked in #92870 RiskLow IMPORTANT: If this backport is for a servicing release, please verify that:
|
Approved by Tactics via email. |
Backport of #92403 to release/8.0
/cc @maraf
Customer Impact
Duplicated marshalling of return value has extra allocations that may leak and has performance impact
Testing
Manually observed generated code. Automated tests that the generated code works. Automated tests (for checking duplicated return value marshalling) tracked in #92870
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.