fix: update types for no-restricted-imports rule
#19060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoshuaKGoldberg
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Looks pretty close to complete to! I verified the types match what's on https://eslint.org/docs/latest/rules/no-restricted-imports.
The only blocker is that there's an inconsistency in the types: the pattern options properly set up ?: never with exactOptionalPropertyTypes, but the path options reduce down to ?: undefined.
Left a couple of stylistic suggestions for the TypeScript syntax too.
|
@JoshuaKGoldberg Thanks for the feedback, I've resolved your comments. PTAL |
JoshuaKGoldberg
previously approved these changes
Nov 1, 2024
nzakas
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Update types for the
no-restricted-importsrule.Is there anything you'd like reviewers to focus on?
NA