Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5d19e1c8d1a6c0b5cd7532d43b707191eaf105b7
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 04bd67a4906d387ecdb8cbc798144dec2db811a5
Choose a head ref
  • 5 commits
  • 10 files changed
  • 3 contributors

Commits on Sep 23, 2024

  1. [Fiber] Log the Render/Commit phases and the gaps in between (#31016)

    A slight behavior change here too is that I now mark the start of the
    commit phase before the BeforeMutationEffect phase. This affects
    `<Profiler>` too.
    
    The named sequences are as follows:
    
    Render -> Suspended or Throttled -> Commit -> Waiting for Paint ->
    Remaining Effects
    
    The Suspended phase is only logged if we delay the Commit due to CSS /
    images.
    
    The Throttled phase is only logged if we delay the commit due to the
    Suspense throttling timer.
    
    <img width="1246" alt="Screenshot 2024-09-20 at 9 14 23 PM"
    src="https://github.com/user-attachments/assets/8d01f444-bb85-472b-9b42-6157d92c81b4">
    
    I don't yet log render phases that don't complete. I think I also need
    to special case renders that or don't commit after being suspended.
    sebmarkbage authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4e9540e View commit details
    Browse the repository at this point in the history
  2. Fix missing trailing / in commit artifacts workflow

    The trailing / was being omitted, so instead of moving the cjs
    directory itself, it would move only its contents instead. This broke
    some internal path assumptions.
    
    Additionally, updates the step to create the react-dom directory prior
    to moving.
    
    ghstack-source-id: b6eedb0c88cd3aa3a786a3d3d280ede5ee81a063
    Pull Request resolved: #31026
    poteto committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    79bcf6e View commit details
    Browse the repository at this point in the history
  3. Allow forcing a build in artifacts workflow dispatch

    Sometimes it is useful to bypass the revision check when we need to make
    changes to the runtime_commit_artifacts script. The `force` input can be
    passed via the GitHub UI for manual runs of the workflow.
    
    ghstack-source-id: cf9e32c01a565d86980277115f41e3e116adf376
    Pull Request resolved: #31027
    poteto committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5b19dc0 View commit details
    Browse the repository at this point in the history
  4. Fix runtime_commit_artifacts workflow

    I messed up the yml syntax and also realized that our script doesn't
    currently handle renames or deletes, so I fixed that
    
    ghstack-source-id: 7d481a951abaabd1a2985c8959d8acb7103ed12e
    Pull Request resolved: #31028
    poteto committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4708fb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Resolve references to deduped owner objects (#30549)

    This is a follow-up from #30528 to not only handle props (the critical
    change), but also the owner ~and stack~ of a referenced element.
    
    ~Handling stacks here is rather academic because the Flight Server
    currently does not deduplicate owner stacks. And if they are really
    identical, we should probably just dedupe the whole element.~ EDIT:
    Removed from the PR.
    
    Handling owner objects on the other hand is an actual requirement as
    reported in vercel/next.js#69545. This problem
    only affects the stable release channel, as the absence of owner stacks
    allows for the specific kind of shared owner deduping as demonstrated in
    the unit test.
    unstubbable authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    04bd67a View commit details
    Browse the repository at this point in the history
Loading