Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6cf8518505b198c58c950976174b1642760d48ee
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 77b637d61200eef4dca4cbe4258da358d6337c7b
Choose a head ref
  • 8 commits
  • 22 files changed
  • 7 contributors

Commits on Oct 14, 2024

  1. [Re-land] Make prerendering always non-blocking: Add missing feature …

    …flag checks (#31238)
    
    This is a partial re-land of
    #31056. We saw breakages surface
    after the original land and had to revert. Now that they've been fixed,
    let's try this again. This time we'll split up the commits to give us
    more control of testing and rollout internally.
    
    Original PR: #31056
    Original Commit:
    2a9fb44
    Revert PR: #31080
    
    Commit description:
    ```
    Neglected to wrap some places in the enableSiblingPrerendering flag.
    ```
    
    Co-authored-by: Andrew Clark <[email protected]>
    jackpope and acdlite authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    13411e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. fix[react-devtools]: fixed timeline profiler tests (#31261)

    Fixes tests against React 18 after
    #31154:
    - Set `supportsTimeline` to true for `Store`.
    - Execute `store.profilerStore.startProfiling` after `legacyRender`
    import, because this is where `react-dom` is imported and renderer is
    registered. We don't yet propagate `isProfiling` flag to newly
    registered renderers, when profiling already started see:
    
    https://github.com/facebook/react/blob/d5bba18b5d81f234657586865248c5b6849599cd/packages/react-devtools-shared/src/hook.js#L203-L204
    hoxyq authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ec2bf02 View commit details
    Browse the repository at this point in the history
  2. [DevTools] Fix React Compiler badging (#31196)

    In #31140 we switched over the uMC polyfill to use memo instead of state
    since memo would FastRefresh properly. However this busted devtools'
    badging of compiled components; this PR fixes it.
    
    TODO: tests
    Co-authored-by: Ruslan Lesiutin <[email protected]>
    
    ---------
    
    Co-authored-by: Ruslan Lesiutin <[email protected]>
    poteto and hoxyq authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9806a4b View commit details
    Browse the repository at this point in the history
  3. React DevTools 6.0.0 -> 6.0.1 (#31263)

    Changes in this release:
    
    * Fix React Compiler badging ([poteto](https://github.com/poteto) in
    [#31196](#31196))
    * fix[react-devtools]: fixed timeline profiler tests
    ([hoxyq](https://github.com/hoxyq) in
    [#31261](#31261))
    * fix[react-devtools]: record timeline data only when supported
    ([hoxyq](https://github.com/hoxyq) in
    [#31154](#31154))
    * refactor[react-devtools]: flatten reload and profile config
    ([hoxyq](https://github.com/hoxyq) in
    [#31132](#31132))
    * fix[react-devtools]: remove all listeners when Agent is shutdown
    ([hoxyq](https://github.com/hoxyq) in
    [#31151](#31151))
    * fix[react-devtools]: removed redundant startProfiling call
    ([hoxyq](https://github.com/hoxyq) in
    [#31131](#31131))
    * refactor[react-devtools/fiber/renderer]: optimize durations resolution
    ([hoxyq](https://github.com/hoxyq) in
    [#31118](#31118))
    * fix[react-devtools]: update profiling status before receiving response
    from backend ([hoxyq](https://github.com/hoxyq) in
    [#31117](#31117))
    * fix[react-devtools]: wrap key string in preformatted text html element
    ([hoxyq](https://github.com/hoxyq) in
    [#31153](#31153))
    * chore[react-devtools]: drop legacy context tests
    ([hoxyq](https://github.com/hoxyq) in
    [#31059](#31059))
    * chore[react-devtools]: add legacy mode error message to the ignore
    list for tests ([hoxyq](https://github.com/hoxyq) in
    [#31060](#31060))
    * fix[react-devtools]: request hook initialization inside http server
    response ([hoxyq](https://github.com/hoxyq) in
    [#31102](#31102))
    * [Flight] Serialize Server Components Props in DEV
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#31105](#31105))
    * Add: reload to profile for Fusebox
    ([EdmondChuiHW](https://github.com/EdmondChuiHW) in
    [#31021](#31021))
    * refactor: allow custom impl of backend realod-to-profile support check
    ([EdmondChuiHW](https://github.com/EdmondChuiHW) in
    [#31048](#31048))
    * fix: use public instance in Fiber renderer and expose it from
    getInspectorDataForViewAtPoint ([hoxyq](https://github.com/hoxyq) in
    [#31068](#31068))
    hoxyq authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c7c68ef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8382581 View commit details
    Browse the repository at this point in the history
  5. [Re-land] Make prerendering always non-blocking (#31268)

    Follows #31238
    
    ___
    
    This is a partial re-land of
    #31056. We saw breakages surface
    after the original land and had to revert. Now that they've been fixed,
    let's try this again. This time we'll split up the commits to give us
    more control of testing and rollout internally.
    
    Original PR: #31056
    Original Commit:
    4c71025
    Revert PR: #31080
    
    Commit description:
    
    > When a synchronous update suspends, and we prerender the siblings, the
    prerendering should be non-blocking so that we can immediately restart
    once the data arrives.
    >
    > This happens automatically when there's a Suspense boundary, because
    we immediately commit the boundary and then proceed to a Retry render,
    which are always concurrent. When there's not a Suspense boundary, there
    is no Retry, so we need to take care to switch from the synchronous work
    loop to the concurrent one, to enable time slicing.
    
    Co-authored-by: Andrew Clark <[email protected]>
    jackpope and acdlite authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6c4bbc7 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. [Flight] Enable sync stack traces for errors and console replay (#31270)

    This was gated behind `enableOwnerStacks` since they share some code
    paths but it's really part of `enableServerComponentLogs`.
    
    This just includes the server-side regular stack on Error/replayed logs
    but doesn't use console.createTask and doesn't include owner stacks.
    sebmarkbage authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    be94b10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    77b637d View commit details
    Browse the repository at this point in the history
Loading