Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d3ce0d3ea9736e1e1bc3e6b6834bc3170b1fa8eb
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f994737d14e83f22ead70e6a41f87353008b73cf
Choose a head ref
  • 14 commits
  • 47 files changed
  • 7 contributors

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    6f90365 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf046e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55dd0b1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Enable disableStringRefs and enableRefAsProp for React Native (Me…

    …ta) (#29177)
    
    ## Summary
    
    Enables the `disableStringRefs` and `enableRefAsProp` feature flags for
    React Native (Meta).
    
    ## How did you test this change?
    
    ```
    $ yarn test
    $ yarn flow fabric
    ```
    yungsters authored May 21, 2024
    Configuration menu
    Copy the full SHA
    7621466 View commit details
    Browse the repository at this point in the history
  2. Fix assertConsoleErrorDev on message mismatch with withoutStack: true (

    …#29198)
    
    ## Summary
    
    ```js
    assertConsoleErrorDev([
      ['Hello', {withoutStack: true}]
    ])
    ```
    
    now errors with a helpful diff message if the message mismatched. See
    first commit for previous behavior.
    
    ## How did you test this change?
    
    - `yarn test --watch
    packages/internal-test-utils/__tests__/ReactInternalTestUtils-test.js`
    eps1lon authored May 21, 2024
    Configuration menu
    Copy the full SHA
    5cc9f69 View commit details
    Browse the repository at this point in the history
  3. [Flight / Flight Reply] Don't clear pending listeners when entering b…

    …locked state (#29201)
    
    Fixes #29200
    
    The cyclic state might have added listeners that will still need to be
    invoked. This happens if we have a cyclic reference AND end up blocked.
    
    We have already cleared these before entering the parsing when we enter
    the CYCLIC state so we they already have the right type. If listeners
    are added during this phase they should carry over to the blocked state.
    
    ---------
    
    Co-authored-by: Hendrik Liebau <[email protected]>
    sebmarkbage and unstubbable authored May 21, 2024
    Configuration menu
    Copy the full SHA
    8f3c052 View commit details
    Browse the repository at this point in the history
  4. [compiler:playground] Wait for build before running playground

    Explicitly waits for the build to finish since the playground requires
    them to run
    
    ghstack-source-id: 0bd7d5272d7fa09dc3a140b82a962dc4a3ae585b
    Pull Request resolved: #29180
    poteto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0a0a5c0 View commit details
    Browse the repository at this point in the history
  5. [Flight] don't overwrite existing chunk listeners in 'wakeChunkIfInit…

    …ialized' (#29204)
    
    Follow up to #29201. If a chunk
    had listeners attached already (e.g. because `.then` was called on the
    chunk returned from `createFromReadableStream`),
    `wakeChunkIfInitialized` would overwrite any listeners added during
    chunk initialization. This caused cyclic [path
    references](#28996) within that
    chunk to never resolve. Fixed by merging the two arrays of listeners.
    lubieowoce authored May 21, 2024
    Configuration menu
    Copy the full SHA
    9b3f909 View commit details
    Browse the repository at this point in the history
  6. [compiler:playground] JS tab is expanded by default

    When using the playground you typically want to see what it outputs, so
    let's make the JS tab expanded by default.
    
    ghstack-source-id: 721bc4c381c50db008058b31e1f976e92eab8548
    Pull Request resolved: #29203
    poteto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b759b71 View commit details
    Browse the repository at this point in the history
  7. [compiler:playground] Update babel.config.js

    Use new defaults
    
    ghstack-source-id: d2da1df69db9f1b01578af6d52ea4a2613769f9b
    Pull Request resolved: #29205
    poteto committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0f58454 View commit details
    Browse the repository at this point in the history
  8. [Fiber] render boundary in fallback if it contains a new stylesheet d…

    …uring sync update (#28965)
    
    Updates Suspensey instances and resources to preload even during urgent
    updates and to potentially suspend.
    
    The current implementation is unchanged for transitions but for sync
    updates if there is a suspense boundary above the resource/instance it
    will be rendered in fallback mode instead.
    
    Note: This behavior is not what we want for images once we make them
    suspense enabled. We will need to have forked behavior here to
    distinguish between stylesheets which should never commit when not
    loaded and images which should commit after a small delay
    gnoff authored May 21, 2024
    Configuration menu
    Copy the full SHA
    217b2cc View commit details
    Browse the repository at this point in the history
  9. [Flight Reply] retain listeners when resolving models with existing l…

    …isteners (#29207)
    
    In #29201 a fix was made to ensure we don't "forget" about some
    listeners when handling cyclic chunks.
    In #29204 another fix was made for a special case when the chunk already
    has listeners before it first resolves.
    
    This implements the followup fix for Flight Reply which was originally
    missed in #29204
    
    Co-authored-by: Janka Uryga <[email protected]>
    gnoff and lubieowoce authored May 21, 2024
    Configuration menu
    Copy the full SHA
    81c5ff2 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    3ac551e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f994737 View commit details
    Browse the repository at this point in the history
Loading