-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move clsx dependency to caret/semver range #316
Conversation
@philwolstenholme is attempting to deploy a commit to the Joe Bell OSS Team on Vercel. A member of the Team first needs to authorize it. |
Cheers Phil! I think that's a great shout Please could you do the same for |
28db694
to
cb9a02d
Compare
Done! |
Oops sorry, I didn't spot the |
@philwolstenholme just run |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@joe-bell the lock file should be updated now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend, thanks again @philwolstenholme
Shipped to |
Awesome, thank you both! |
Description
Fixes #317
I noticed when doing some bundle size analysis of my project that npm wasn't deduping my dependency of
clsx
and CVA's dependency ofclsx
.Was the dependency meant to be hardcoded to
2.1.0
? This PR changes it to^2.1.0
so that npm is free to deduplicate the dependency and share the same (major) version ofclsx
across my project code and CVA.Additional context
This saves users having to do something like this in their
package.json
to override the duplicated dependency:What is the purpose of this pull request?