Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocha.css contains :is() and broke in older browsers #5225

Closed
danny0838 opened this issue Oct 11, 2024 · 3 comments · Fixed by #5227
Closed

mocha.css contains :is() and broke in older browsers #5225

danny0838 opened this issue Oct 11, 2024 · 3 comments · Fixed by #5227
Labels
area: browser browser-specific status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer

Comments

@danny0838
Copy link
Contributor

danny0838 commented Oct 11, 2024

According to MDN, :is() is supported since Chromium 88 and Firefox 78.

Not sure what browser versions do mocha intend to support. Our project currently targets Chromium >= 73 and Firefox >= 68, and this CSS issue prevents us from upgrading mocha library (from v10.3.0).

@JoshuaKGoldberg
Copy link
Member

prevents us from upgrading mocha library.

Can you be more specific, please? What's the actual visual bug that's preventing you? It'd be helpful for us as maintainers to triage this if you could provide, for example, screenshots showing the problem and/or a way for us to quickly reproduce the issue.


Not sure what browser versions do mocha intend to support.

Good question. I filed #5226 just now to make this more explicit. The only explicit version indicator I could find was that Mocha 10 supports Node 14.

Some details on Node 14:

For reference, equivalent browser versions end of April 2020 were:

I also asked in our Discord if anybody knows the explicit browser version support range of Mocha: https://discord.com/channels/1169379988978536528/1169381309144109177/1294295572852772887. cc @mochajs/maintenance-crew - surely this is documented somewhere?

For context, #5027 - there's a lot of info that's been lost to time & we need to pick up.

@danny0838
Copy link
Contributor Author

danny0838 commented Oct 11, 2024

Can you be more specific, please? What's the actual visual bug that's preventing you? It'd be helpful for us as maintainers to triage this if you could provide, for example, screenshots showing the problem and/or a way for us to quickly reproduce the issue.

I think saying that all the issue is :is()-related is specific enough—simply trace all :is() usage will find what are affected. FYI the current mocha version our project use is v10.3.0, and when using the current version (v10.7.3) there is no other CSS or script error besides this.

@danny0838
Copy link
Contributor Author

PR provided. No matter what older browsers this project intend to support, removing :is() can at least fix the current downward compatibility issue and make the code more consistent with older existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: browser browser-specific status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants