feat: optimize []string annotation

[dongjiang1989]

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

optimize []string kubebuilder annotation

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

• CHANGE (fix or feature that would cause existing functionality to not work as expected)
• FEATURE (non-breaking change which adds functionality)
• BUGFIX (non-breaking change which fixes an issue)
• [] ENHANCEMENT (non-breaking change which improves existing functionality)
• NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

optimize []string annotation

[simonpasquier]

Thanks for the PR! We can't change validations on v1 APIs unfortunately (at least not being stricter as it could break users). I'd also be reluctant to change v1beta1 APIs and v1alpha1 AlertmanagerConfig is frozen. Which basically leaves us with the v1alpha1 ScrapeConfig CRD.

We'd need e2e tests too for each added validation.

cc @mviswanathsai

[dongjiang1989]

Thanks for the PR! We can't change validations on v1 APIs unfortunately (at least not being stricter as it could break users). I'd also be reluctant to change v1beta1 APIs and v1alpha1 AlertmanagerConfig is frozen. Which basically leaves us with the v1alpha1 ScrapeConfig CRD.

We'd need e2e tests too for each added validation.

cc @mviswanathsai

Thanks. @simonpasquier
I Got it. Change CRD and add e2e test cases done.

[nicolastakashi]

Thanks for taking it @dongjiang1989 I think it's not a ENHANCEMENT i think it's a NONE on the change log, wdyt @simonpasquier ?

[dongjiang1989]

Thanks for taking it @dongjiang1989 I think it's not a ENHANCEMENT i think it's a NONE on the change log, wdyt @simonpasquier ?

Thanks @nicolastakashi . I got it. Change it done.

[simonpasquier]

Thanks! Technically it's a CHANGE since we're hardening the API validations.