Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyasn 0.5.0.dev2 breaks ldap3 2.9.1 #12

Closed
mhils opened this issue Aug 16, 2022 · 3 comments
Closed

pyasn 0.5.0.dev2 breaks ldap3 2.9.1 #12

mhils opened this issue Aug 16, 2022 · 3 comments

Comments

@mhils
Copy link

mhils commented Aug 16, 2022

pyasn1 from main currently breaks ldap3 2.9.1:

    import ldap3
  File "/home/user/venv/lib/python3.10/site-packages/ldap3/__init__.py", line 141, in <module>
    from .core.connection import Connection
  File "/home/user/venv/lib/python3.10/site-packages/ldap3/core/connection.py", line 38, in <module>
    from ..extend import ExtendedOperationsRoot
  File "/home/user/venv/lib/python3.10/site-packages/ldap3/extend/__init__.py", line 29, in <module>
    from .microsoft.dirSync import DirSync
  File "/home/user/venv/lib/python3.10/site-packages/ldap3/extend/microsoft/dirSync.py", line 27, in <module>
    from ...protocol.microsoft import dir_sync_control, extended_dn_control, show_deleted_control
  File "/home/user/venv/lib/python3.10/site-packages/ldap3/protocol/microsoft.py", line 32, in <module>
    from .controls import build_control
  File "/home/user/venv/lib/python3.10/site-packages/ldap3/protocol/controls.py", line 27, in <module>
    from ..utils.asn1 import encode
  File "/home/user/venv/lib/python3.10/site-packages/ldap3/utils/asn1.py", line 80, in <module>
    encode = Encoder(customTagMap, customTypeMap)
TypeError: Encoder.__init__() takes 1 positional argument but 3 were given

Steps to reproduce:

git clone pyasn1
pip install -e ./pyasn1

pip install ldap3
python -c "import ldap3"
@tiran
Copy link

tiran commented Aug 16, 2022

Issues was introduced in 8393983

@tiran
Copy link

tiran commented Aug 23, 2022

@droideck
Copy link

I've checked the reproduction steps and everything seems to work now.
Thanks!

Closing as solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants