Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sphinx build and check example file existence #2712

Merged
merged 2 commits into from
May 18, 2024
Merged

Fix Sphinx build and check example file existence #2712

merged 2 commits into from
May 18, 2024
+13 −1

Conversation

kdeldycke
Copy link
Contributor

There's an issue that was introduced in #2442 that breaks the Sphinx build. This is a hotfix.

@kdeldycke
Fix Sphinx build
Loading
Loading status checks…
d929d13 
Follow up on #2442
@kdeldycke kdeldycke changed the title Fix Sphinx build Fix Sphinx build and check example file existence May 18, 2024
@kdeldycke
Test the existence of the example file
Loading
Loading status checks…
afd62f5
@kdeldycke
Copy link
Contributor Author

Sorry @Anteru, but an issue was introduced with the #2442 PR you just merged. Which breaks the building of the Sphinx documentation. This PR fixes this.

And also, to prevent the problem to be triggered again, I added a safeguard in the unit tests.

@Anteru
Copy link
Collaborator

Anteru commented May 18, 2024

Good catch, thanks!

@Anteru Anteru merged commit d90b25d into pygments:master May 18, 2024
13 checks passed
@kdeldycke kdeldycke deleted the fix-sphinx-build branch May 18, 2024 15:42
@kdeldycke kdeldycke mentioned this pull request May 19, 2024
Merged
@Anteru Anteru added the A-docs area: changes to documentation/docstrings label Jan 5, 2025
@Anteru Anteru added this to the 2.19.0 milestone Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-docs area: changes to documentation/docstrings
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdeldycke @Anteru