feat!: throw an error when no file was found #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3faaf9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tassioFront
commented
Sep 25, 2024
src/serve.ts
Outdated
| ) | ||
| updateFileMapFromTargets(copyTargets, fileMap) | ||
| } catch (e) { | ||
| config.logger.error(formatConsole(pc.red((e as Error).toString()))) | ||
| !silent && |
There was a problem hiding this comment.
looks like it was missed. All logs here are silenceable
|
@sapphi-red, any news here? 😅 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reasons here
important points:
silentto thecopyAll). Another alternative I thought was to return an array of failed results and useoutputCopyLogto show them, then I would not need to pass thesilentflag.silentas it looks for this purpose. I don't think make sense to create another flagEvidence:
build
silent=false
silent=true
server
silent=false
silent=true (the server keeps running, but there is a logger.error)
