Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support use storybook to dev rslib module federation format assets and also support hmr #349

Merged
merged 24 commits into from
Nov 11, 2024

Conversation

nyqykk
Copy link
Member

@nyqykk nyqykk commented Oct 30, 2024

Summary

Support use storybook to dev rslib module federation format assets and also support hmr
Many capabilities are integrated here.
rspack-contrib/storybook-rsbuild#165
module-federation/core#3131

Related Links

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 156ca80
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6731d70042f0f300080c9507
😎 Deploy Preview https://deploy-preview-349--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework self-requested a review October 30, 2024 10:28
@Timeless0911
Copy link
Contributor

The lockfile need to be regenerated, run git clean -f -d -x and copy lockfile on main branch, make sure corepack enabled and run pnpm install

Copy link

codspeed-hq bot commented Oct 31, 2024

CodSpeed Performance Report

Merging #349 will not alter performance

Comparing feat/dev-mf-assets (156ca80) with main (7dd9a48)

Summary

✅ 5 untouched benchmarks

@nyqykk
Copy link
Member Author

nyqykk commented Nov 6, 2024

Many capabilities are integrated here.
rspack-contrib/storybook-rsbuild#165
module-federation/core#3131

@fi3ework
Copy link
Member

fi3ework commented Nov 6, 2024

I'll release a new version of storybook-addon-rsllib.

@fi3ework
Copy link
Member

fi3ework commented Nov 6, 2024

The lockfile changed too much, you could try to reset lockfile to main branch first then re-run pnpm i to update it.

@nyqykk
Copy link
Member Author

nyqykk commented Nov 6, 2024

The lockfile changed too much, you could try to reset lockfile to main branch first then re-run pnpm i to update it.

it seems normal change, you can also have a try, i get the same result

@fi3ework
Copy link
Member

fi3ework commented Nov 6, 2024

The initial investigation appears to be caused by peer dep doppelganger.

@fi3ework
Copy link
Member

fi3ework commented Nov 6, 2024

@Timeless0911 PTAL 0aa8efc. I disabled auto-install-peers.

@Timeless0911
Copy link
Contributor

Timeless0911 commented Nov 6, 2024

@Timeless0911 PTAL 0aa8efc. I disabled auto-install-peers.

LGTM, it's more strict now. And is this PR going to be merged right now?

@fi3ework
Copy link
Member

I will add --lib args afterwards.

@nyqykk nyqykk merged commit d52e410 into main Nov 11, 2024
20 checks passed
@nyqykk nyqykk deleted the feat/dev-mf-assets branch November 11, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants