Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: target default to node #398

Merged
merged 3 commits into from
Nov 11, 2024
Merged

feat!: target default to node #398

merged 3 commits into from
Nov 11, 2024

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Nov 11, 2024 •
edited
Loading

Summary

Breaking change

Set output.target default to node to align with Tsup and Modern.js Module, which is different from Rsbuild default.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit b4f52f2
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6731d0728094f800083b6900
😎 Deploy Preview https://deploy-preview-398--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now remove this chapter:

https://lib.rsbuild.dev/guide/migration/tsup#platform

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #398 will not alter performance

Comparing feat/default-target (1a14add) with main (95e1179)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework enabled auto-merge (squash) November 11, 2024 10:00
@fi3ework fi3ework merged commit 7dd9a48 into main Nov 11, 2024
18 checks passed
@fi3ework fi3ework deleted the feat/default-target branch November 11, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@fi3ework fi3ework fi3ework approved these changes

Assignees
No one assigned
Labels
change: feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Timeless0911 @chenjiahan @fi3ework