feat(nuxt): Add server error hook #12796
Merged
+133
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jul 8, 2024
lforst
reviewed
Jul 8, 2024
|
|
||
| if (context) { | ||
| captureException(error, { | ||
| captureContext: { contexts: { nuxt: context } }, |
There was a problem hiding this comment.
m: I would be more selective in what we record here instead of dumping the entire context object in here. It could become a problem if context suddenly starts containing PII, becomes very large, or circular in a future nitro update.
There was a problem hiding this comment.
yes ideally we:
- We parse the incoming nuxt context and extract the fields we care about
- We put that in a nuxt context attached to the sentry event
- Document the nuxt context in the develop docs
lforst
approved these changes
Jul 9, 2024
Comment on lines
8
to
13
| // Do not handle 404 and 422 | ||
| if (error instanceof H3Error) { | ||
| if (error.statusCode === 404 || error.statusCode === 422) { | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
l/m: We could arguably skip all 4xxs (also 3xxs if that can ever happen).
Lms24
approved these changes
Jul 9, 2024
Comment on lines
15
to
24
| if (errorContext) { | ||
| const structuredContext = extractErrorContext(errorContext); | ||
|
|
||
| captureException(error, { | ||
| captureContext: { contexts: { nuxt: structuredContext } }, | ||
| mechanism: { handled: false }, | ||
| }); | ||
| } else { | ||
| captureException(error, { mechanism: { handled: false } }); | ||
| } |
There was a problem hiding this comment.
l (feel free to disregard): WDYT about calling captureException only once and setting captureContext depending on errorContext
| tags: undefined, | ||
| }; | ||
|
|
||
| if (errorContext) { |
There was a problem hiding this comment.
l: do we need this guard? i.e. can CapturedErrorContext be undefined?
s1gr1d
added a commit
that referenced
this pull request
Jul 9, 2024
Preparing `@sentry/nuxt` for a release (experimental) Merge after this PR: #12796
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports errors thrown in nitro. Tests will be added when adding the E2E test application.
closes #12795