File Structure and Best Practices For AngularJS
File Structure and Best Practices For AngularJS
Foundation
Lets get to best practices and what you should be doing to build
scalable and maintainable AngularJS apps that your coworkers will
love you for. An ideal AngularJS app structure should be
modularized into very specific functions. We also want to take
advantage of the wonderful AngularJS directives to further
compartmentalize our apps. Take a look at a sample directory
structure below:
index.html
INDEX.HTML
The index.html lives at the root of front-end structure.
The index.html file will primarily handle loading in all the libraries and
Angular elements.
ASSETS FOLDER
The assets folder is also pretty standard. It will contain all the assets
needed for your app that are not related your AngularJS code. There
are many great ways to organize this directory but they are out of
scope for this article. The example above is good enough for most
apps.
APP FOLDER
This is where the meat of your AngularJS app will live. We have two
subfolders in here and a couple JavaScript files at the root of the
folder. The app.module.js file will handle the setup of your app, load in
AngularJS dependencies and so on. The app.route.js file will handle
all the routes and the route configuration. After that we have two
subfolders componentsand shared. Lets dive into those next.
COMPONENTS FOLDER
The components folder will contain the actual sections for your Angular
app. These will be the static views ,directives and services for that
specific section of the site (think an admin users section, gallery
creation section, etc). Each page should have its own subfolder with
its own controller, services, and HTML files.
This can be seen as the simpler folder structure shown earlier in this
article, just broken down into sections. So you could essentially
think of this as multiple mini Angular applications inside of
your giant Angular application.
SHARED FOLDER
The shared folder will contain the individual features that your app will
have. These features will ideally be directives that you will want to
reuse on multiple pages.
Now this slider is accessible from any part of our site so were not
reinventing the wheel. We also just have to change it in one place,
the shared folder and it will update sitewide.
You may not want to necessarily have just one giant .js file for your
entire app, but concatenating your app into a few logical files like:
CODE MAINTAINABILITY
Follow the approach above will logically compartmentalize your apps
and you will easily be able to locate and edit code.
SCALABLE
Your code will be much easier to scale. Adding new directives and
pages will not add bloat to existing folders. Onboarding new
developers should also be much easier once the structure is
explained. Additionally, with this approach, you will be able to drop
features in and out of your app with relative ease so testing new
functionality or removing it should be a breeze.
DEBUGGING
Debugging your code will be much easier with this modularized
approach to app development. It will be easier to find the offending
pieces of code and fix them.
TESTING
Writing test scripts and testing modernized apps is a whole lot easier
then non-modularized ones.
#In Conclusion
To conclude, this article covered some of the best practices in
regards to structuring an AngularJS app. It is easy to ignore good
practices in order to save time upfront. We all have a tendency to
just want to start writing code. Sometimes this passion can hurt us in
the long run when our awesome apps grow and become popular and
then were stuck rewriting or even worse maintaining badly thought
out code. I hope this article had some helpful tips.
Single Responsibility
Rule of 1
[Style Y001]
Define 1 component per file, recommended to be less than 400 lines of code.
Why?: One component per file promotes easier unit testing and mocking.
Why?: One component per file makes it far easier to read, maintain, and
avoid collisions with teams in source control.
Why?: One component per file avoids hidden bugs that often arise when
combining components in a file where they may share variables, create
unwanted closures, or unwanted coupling with dependencies.
The following example defines the app module and its dependencies, defines
a controller, and defines a factory all in the same file.
/* avoid */
angular
.module('app', ['ngRoute'])
.controller('SomeController', SomeController)
.factory('someFactory', someFactory);
function SomeController() { }
function someFactory() { }
The same components are now separated into their own files.
/* recommended */
// app.module.js
angular
.module('app', ['ngRoute']);
/* recommended */
// some.controller.js
angular
.module('app')
.controller('SomeController', SomeController);
function SomeController() { }
/* recommended */
// some.factory.js
angular
.module('app')
.factory('someFactory', someFactory);
function someFactory() { }
Back to top
Small Functions
[Style Y002]
Why?: Small functions are easier to test, especially when they do one thing
and serve one purpose.
Why?: Small functions help avoid hidden bugs that come with large
functions that share variables with external scope, create unwanted closures,
or unwanted coupling with dependencies.
Back to top
IIFE
JavaScript Scopes
[Style Y010]
Why?: An IIFE removes variables from the global scope. This helps prevent
variables and function declarations from living longer than expected in the
global scope, which also helps avoid variable collisions.
Why?: When your code is minified and bundled into a single file for
deployment to a production server, you could have collisions of variables
and many global variables. An IIFE protects you against both of these by
providing variable scope for each file.
/* avoid */
// logger.js
angular
.module('app')
.factory('logger', logger);
// storage.js
angular
.module('app')
.factory('storage', storage);
// logger.js
(function() {
'use strict';
angular
.module('app')
.factory('logger', logger);
function logger() { }
})();
// storage.js
(function() {
'use strict';
angular
.module('app')
.factory('storage', storage);
function storage() { }
})();
Note: For brevity only, the rest of the examples in this guide may omit the
IIFE syntax.
Note: IIFE's prevent test code from reaching private members like regular
expressions or helper functions which are often good to unit test directly on
their own. However you can test these through accessible members or by
exposing them through their own component. For example placing helper
functions, regular expressions or constants in their own factory or constant.
Back to top
Modules
[Style Y020]
Why?: Unique names help avoid module name collisions. Separators help
define modules and their submodule hierarchy. For example app may be
your root module while app.dashboard and app.users may be modules that
are used as dependencies of app.
[Style Y021]
/* avoid */
var app = angular.module('app', [
'ngAnimate',
'ngRoute',
'app.shared',
'app.dashboard'
]);
/* recommended */
angular
.module('app', [
'ngAnimate',
'ngRoute',
'app.shared',
'app.dashboard'
]);
Getters
[Style Y022]
When using a module, avoid using a variable and instead use chaining with
the getter syntax.
Why?: This produces more readable code and avoids variable collisions or
leaks.
/* avoid */
var app = angular.module('app');
app.controller('SomeController', SomeController);
function SomeController() { }
/* recommended */
angular
.module('app')
.controller('SomeController', SomeController);
function SomeController() { }
Setting vs Getting
[Style Y023]
Why?: A module should only be created once, then retrieved from that point
and after.
/* recommended */
// to set a module
angular.module('app', []);
// to get a module
angular.module('app');
[Style Y024]
Why?: This produces more readable code, is much easier to debug, and
reduces the amount of nested callback code.
/* avoid */
angular
.module('app')
.controller('DashboardController', function() { })
.factory('logger', function() { });
/* recommended */
// dashboard.js
angular
.module('app')
.controller('DashboardController', DashboardController);
function DashboardController() { }
// logger.js
angular
.module('app')
.factory('logger', logger);
function logger() { }
Back to top
Controllers
[Style Y030]
Use the controllerAs syntax over the classic controller with $scope syntax.
Why?: Controllers are constructed, "newed" up, and provide a single new
instance, and the controllerAs syntax is closer to that of a JavaScript
constructor than the classic $scope syntax.
Why?: It promotes the use of binding to a "dotted" object in the View
(e.g. customer.name instead of name), which is more contextual, easier to read,
and avoids any reference issues that may occur without "dotting".
Why?: Helps avoid using $parent calls in Views with nested controllers.
<!-- avoid -->
<div ng-controller="CustomerController">
{{ name }}
</div>
<!-- recommended -->
<div ng-controller="CustomerController as customer">
{{ customer.name }}
</div>
Use the controllerAs syntax over the classic controller with $scope syntax.
The controllerAs syntax uses this inside controllers which gets bound
to $scope
Why?: controllerAs is syntactic sugar over $scope. You can still bind to the
View and still access $scope methods.
Why?: Helps avoid the temptation of using $scope methods inside a
controller when it may otherwise be better to avoid them or move the
method to a factory, and reference them from the controller. Consider
using $scope in a controller only when needed. For example when publishing
and subscribing events using $emit, $broadcast, or $on.
/* avoid */
function CustomerController($scope) {
$scope.name = {};
$scope.sendMessage = function() { };
}
/* recommended - but see next section */
function CustomerController() {
this.name = {};
this.sendMessage = function() { };
}
controllerAs with vm
[Style Y032]
Use a capture variable for this when using the controllerAs syntax. Choose a
consistent variable name such as vm, which stands for ViewModel.
Why?: The this keyword is contextual and when used within a function
inside a controller may change its context. Capturing the context
of this avoids encountering this problem.
/* avoid */
function CustomerController() {
this.name = {};
this.sendMessage = function() { };
}
/* recommended */
function CustomerController() {
var vm = this;
vm.name = {};
vm.sendMessage = function() { };
}
Note: You can avoid any jshint warnings by placing the comment above the
line of code. However it is not needed when the function is named using
UpperCasing, as this convention means it is a constructor function, which is
what a controller is in Angular.
Note: When working with larger codebases, using a more descriptive name
can help ease cognitive overhead & searchability. Avoid overly verbose
names that are cumbersome to type.
[Style Y033]
Place bindable members at the top of the controller, alphabetized, and not
spread through the controller code.
Why?: Placing bindable members at the top makes it easy to read and helps
you instantly identify which members of the controller can be bound and
used in the View.
Why?: Setting anonymous functions in-line can be easy, but when those
functions are more than 1 line of code they can reduce the readability.
Defining the functions below the bindable members (the functions will be
hoisted) moves the implementation details down, keeps the bindable
members up top, and makes it easier to read.
/* avoid */
function SessionsController() {
var vm = this;
vm.gotoSession = function() {
/* ... */
};
vm.refresh = function() {
/* ... */
};
vm.search = function() {
/* ... */
};
vm.sessions = [];
vm.title = 'Sessions';
}
/* recommended */
function SessionsController() {
var vm = this;
vm.gotoSession = gotoSession;
vm.refresh = refresh;
vm.search = search;
vm.sessions = [];
vm.title = 'Sessions';
////////////
function gotoSession() {
/* */
}
function refresh() {
/* */
}
function search() {
/* */
}
}
Note: If the function is a 1 liner consider keeping it right up top, as long as
readability is not affected.
/* avoid */
function SessionsController(data) {
var vm = this;
vm.gotoSession = gotoSession;
vm.refresh = function() {
/**
* lines
* of
* code
* affects
* readability
*/
};
vm.search = search;
vm.sessions = [];
vm.title = 'Sessions';
}
/* recommended */
function SessionsController(sessionDataService) {
var vm = this;
vm.gotoSession = gotoSession;
vm.refresh = sessionDataService.refresh; // 1 liner is OK
vm.search = search;
vm.sessions = [];
vm.title = 'Sessions';
}
[Style Y034]
Why?: Placing bindable members at the top makes it easy to read and helps
you instantly identify which members of the controller can be bound and
used in the View. (Same as above.)
Why?: Placing the implementation details of a function later in the file moves
that complexity out of view so you can see the important stuff up top.
Why?: Function declarations are hoisted so there are no concerns over using
a function before it is defined (as there would be with function expressions).
Why?: You never have to worry with function declarations that moving var
a before var b will break your code because a depends on b.
/**
* avoid
* Using function expressions.
*/
function AvengersController(avengersService, logger) {
var vm = this;
vm.avengers = [];
vm.title = 'Avengers';
vm.getAvengers = getAvengers;
activate();
}
Notice that the important stuff is scattered in the preceding example. In the
example below, notice that the important stuff is up top. For example, the
members bound to the controller such as vm.avengers and vm.title. The
implementation details are down below. This is just easier to read.
/*
* recommend
* Using function declarations
* and bindable members up top.
*/
function AvengersController(avengersService, logger) {
var vm = this;
vm.avengers = [];
vm.getAvengers = getAvengers;
vm.title = 'Avengers';
activate();
function activate() {
return getAvengers().then(function() {
logger.info('Activated Avengers View');
});
}
function getAvengers() {
return avengersService.getAvengers().then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
}
[Style Y035]
Why?: Logic in a service can more easily be isolated in a unit test, while the
calling logic in the controller can be easily mocked.
/* avoid */
function OrderController($http, $q, config, userInfo) {
var vm = this;
vm.checkCredit = checkCredit;
vm.isCreditOk;
vm.total = 0;
function checkCredit() {
var settings = {};
// Get the credit service base URL from config
// Set credit service required headers
// Prepare URL query string or data object with request data
// Add user-identifying info so service gets the right credit
limit for this user.
// Use JSONP for this browser if it doesn't support CORS
return $http.get(settings)
.then(function(data) {
// Unpack JSON data in the response object
// to find maxRemainingAmount
vm.isCreditOk = vm.total <= maxRemainingAmount
})
.catch(function(error) {
// Interpret error
// Cope w/ timeout? retry? try alternate service?
// Re-reject with appropriate error for a user to see
});
};
}
/* recommended */
function OrderController(creditService) {
var vm = this;
vm.checkCredit = checkCredit;
vm.isCreditOk;
vm.total = 0;
function checkCredit() {
return creditService.isOrderTotalOk(vm.total)
.then(function(isOk) { vm.isCreditOk = isOk; })
.catch(showError);
};
}
Keep Controllers Focused
[Style Y037]
Define a controller for a view, and try not to reuse the controller for other
views. Instead, move reusable logic to factories and keep the controller
simple and focused on its view.
Why?: Reusing controllers with several views is brittle and good end-to-end
(e2e) test coverage is required to ensure stability across large applications.
Assigning Controllers
[Style Y038]
When a controller must be paired with a view and either component may be
re-used by other controllers or views, define controllers along with their
routes.
Note: If a View is loaded via another means besides a route, then use the ng-
controller="Avengers as vm" syntax.
Why?: Pairing the controller in the route allows different routes to invoke
different pairs of controllers and views. When controllers are assigned in the
view using ng-controller, that view is always associated with the same
controller.
/* avoid - when using with a route and dynamic pairing is desired */
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html'
});
}
<!-- avengers.html -->
<div ng-controller="AvengersController as vm">
</div>
/* recommended */
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html',
controller: 'Avengers',
controllerAs: 'vm'
});
}
<!-- avengers.html -->
<div>
</div>
Back to top
Services
Singletons
[Style Y040]
Services are instantiated with the new keyword, use this for public methods
and variables. Since these are so similar to factories, use a factory instead for
consistency.
Note: All Angular services are singletons. This means that there is only one
instance of a given service per injector.
// service
angular
.module('app')
.service('logger', logger);
function logger() {
this.logError = function(msg) {
/* */
};
}
// factory
angular
.module('app')
.factory('logger', logger);
function logger() {
return {
logError: function(msg) {
/* */
}
};
}
Back to top
Factories
Single Responsibility
[Style Y050]
Singletons
[Style Y051]
Factories are singletons and return an object that contains the members of
the service.
[Style Y052]
Expose the callable members of the service (its interface) at the top, using a
technique derived from the Revealing Module Pattern.
Why?: Placing the callable members at the top makes it easy to read and
helps you instantly identify which members of the service can be called and
must be unit tested (and/or mocked).
Why?: This is especially helpful when the file gets longer as it helps avoid the
need to scroll to see what is exposed.
Why?: Setting functions as you go can be easy, but when those functions are
more than 1 line of code they can reduce the readability and cause more
scrolling. Defining the callable interface via the returned service moves the
implementation details down, keeps the callable interface up top, and makes
it easier to read.
/* avoid */
function dataService() {
var someValue = '';
function save() {
/* */
};
function validate() {
/* */
};
return {
save: save,
someValue: someValue,
validate: validate
};
}
/* recommended */
function dataService() {
var someValue = '';
var service = {
save: save,
someValue: someValue,
validate: validate
};
return service;
////////////
function save() {
/* */
};
function validate() {
/* */
};
}
This way bindings are mirrored across the host object, primitive values
cannot update alone using the revealing module pattern.
Function Declarations to Hide Implementation Details
[Style Y053]
Why?: Placing the implementation details of a function later in the file moves
that complexity out of view so you can see the important stuff up top.
Why?: Function declarations are hoisted so there are no concerns over using
a function before it is defined (as there would be with function expressions).
Why?: You never have to worry with function declarations that moving var
a before var b will break your code because a depends on b.
/**
* avoid
* Using function expressions
*/
function dataservice($http, $location, $q, exception, logger) {
var isPrimed = false;
var primePromise;
var service = {
getAvengersCast: getAvengersCast,
getAvengerCount: getAvengerCount,
getAvengers: getAvengers,
ready: ready
};
return service;
}
/**
* recommended
* Using function declarations
* and accessible members up top.
*/
function dataservice($http, $location, $q, exception, logger) {
var isPrimed = false;
var primePromise;
var service = {
getAvengersCast: getAvengersCast,
getAvengerCount: getAvengerCount,
getAvengers: getAvengers,
ready: ready
};
return service;
////////////
function getAvengers() {
// implementation details go here
}
function getAvengerCount() {
// implementation details go here
}
function getAvengersCast() {
// implementation details go here
}
function prime() {
// implementation details go here
}
function ready(nextPromises) {
// implementation details go here
}
}
Back to top
Data Services
Refactor logic for making data operations and interacting with data to a
factory. Make data services responsible for XHR calls, local storage, stashing
in memory, or any other data operations.
Why?: This makes it easier to test (mock or real) the data calls when testing a
controller that uses a data service.
Why?: Data service implementation may have very specific code to handle
the data repository. This may include headers, how to talk to the data, or
other services such as $http. Separating the logic into a data service
encapsulates this logic in a single place hiding the implementation from the
outside consumers (perhaps a controller), also making it easier to change
the implementation.
/* recommended */
// dataservice factory
angular
.module('app.core')
.factory('dataservice', dataservice);
function getAvengers() {
return $http.get('/api/maa')
.then(getAvengersComplete)
.catch(getAvengersFailed);
function getAvengersComplete(response) {
return response.data.results;
}
function getAvengersFailed(error) {
logger.error('XHR Failed for getAvengers.' + error.data);
}
}
}
Note: The data service is called from consumers, such as a controller, hiding
the implementation from the consumers, as shown below.
/* recommended */
activate();
function activate() {
return getAvengers().then(function() {
logger.info('Activated Avengers View');
});
}
function getAvengers() {
return dataservice.getAvengers()
.then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
}
[Style Y061]
When calling a data service that returns a promise such as $http, return a
promise in your calling function too.
Why?: You can chain the promises together and take further action after the
data call completes and resolves or rejects the promise.
/* recommended */
activate();
function activate() {
/**
* Step 1
* Ask the getAvengers function for the
* avenger data and wait for the promise
*/
return getAvengers().then(function() {
/**
* Step 4
* Perform an action on resolve of final promise
*/
logger.info('Activated Avengers View');
});
}
function getAvengers() {
/**
* Step 2
* Ask the data service for the data and wait
* for the promise
*/
return dataservice.getAvengers()
.then(function(data) {
/**
* Step 3
* set the data and resolve the promise
*/
vm.avengers = data;
return vm.avengers;
});
}
Back to top
Directives
[Style Y070]
Create one directive per file. Name the file for the directive.
Why?: It is easy to mash all the directives in one file, but difficult to then
break those out so some are shared across apps, some across modules,
some just for one module.
Note: "Best Practice: Directives should clean up after themselves. You can
use element.on('$destroy', ...) or scope.$on('$destroy', ...) to run a
clean-up function when the directive is removed" ... from the Angular
documentation.
/* avoid */
/* directives.js */
angular
.module('app.widgets')
/* sales directive that can be used anywhere across the sales app */
.directive('salesCustomerInfo', salesCustomerInfo)
function orderCalendarRange() {
/* implementation details */
}
function salesCustomerInfo() {
/* implementation details */
}
function sharedSpinner() {
/* implementation details */
}
/* recommended */
/* calendar-range.directive.js */
/**
* @desc order directive that is specific to the order module at a company
named Acme
* @example <div acme-order-calendar-range></div>
*/
angular
.module('sales.order')
.directive('acmeOrderCalendarRange', orderCalendarRange);
function orderCalendarRange() {
/* implementation details */
}
/* recommended */
/* customer-info.directive.js */
/**
* @desc sales directive that can be used anywhere across the sales app at
a company named Acme
* @example <div acme-sales-customer-info></div>
*/
angular
.module('sales.widgets')
.directive('acmeSalesCustomerInfo', salesCustomerInfo);
function salesCustomerInfo() {
/* implementation details */
}
/* recommended */
/* spinner.directive.js */
/**
* @desc spinner directive that can be used anywhere across apps at a
company named Acme
* @example <div acme-shared-spinner></div>
*/
angular
.module('shared.widgets')
.directive('acmeSharedSpinner', sharedSpinner);
function sharedSpinner() {
/* implementation details */
}
Note: There are many naming options for directives, especially since they
can be used in narrow or wide scopes. Choose one that makes the directive
and its file name distinct and clear. Some examples are below, but see
the Naming section for more recommendations.
[Style Y072]
When manipulating the DOM directly, use a directive. If alternative ways can
be used such as using CSS to set styles or the animation services, Angular
templating, ngShow or ngHide, then use those instead. For example, if the
directive simply hides and shows, use ngHide/ngShow.
Why?: DOM manipulation can be difficult to test, debug, and there are often
better ways (e.g. CSS, animations, templates)
[Style Y073]
[Style Y074]
Why?: While we can allow the directive to be used as a class, if the directive
is truly acting as an element it makes more sense as an element or at least
as an attribute.
function myCalendarRange() {
var directive = {
link: link,
templateUrl: '/template/is/located/here.html',
restrict: 'C'
};
return directive;
[Style Y075]
Note: The directive below demonstrates some of the ways you can use
scope inside of link and directive controllers, using controllerAs. I in-lined
the template just to keep it all in one place.
Note: Note that the directive's controller is outside the directive's closure.
This style eliminates issues where the injection gets created as unreachable
code after a return.
<div my-example max="77"></div>
angular
.module('app')
.directive('myExample', myExample);
function myExample() {
var directive = {
restrict: 'EA',
templateUrl: 'app/feature/example.directive.html',
scope: {
max: '='
},
link: linkFunc,
controller: ExampleController,
// note: This would be 'ExampleController' (the exported
controller name, as string)
// if referring to a defined controller in its separate file.
controllerAs: 'vm',
bindToController: true // because the scope is isolated
};
return directive;
ExampleController.$inject = ['$scope'];
function ExampleController($scope) {
// Injecting $scope just for comparison
var vm = this;
vm.min = 3;
Note: You can also name the controller when you inject it into the link
function and access directive attributes as properties of the controller.
[Style Y076]
function myExample() {
var directive = {
restrict: 'EA',
templateUrl: 'app/feature/example.directive.html',
scope: {
max: '='
},
controller: ExampleController,
controllerAs: 'vm',
bindToController: true
};
return directive;
}
function ExampleController() {
var vm = this;
vm.min = 3;
console.log('CTRL: vm.min = %s', vm.min);
console.log('CTRL: vm.max = %s', vm.max);
}
<!-- example.directive.html -->
<div>hello world</div>
<div>max={{vm.max}}<input ng-model="vm.max"/></div>
<div>min={{vm.min}}<input ng-model="vm.min"/></div>
Back to top
Resolving Promises
[Style Y080]
Note: If you need to conditionally cancel the route before you start using the
controller, use a route resolve instead.
/* avoid */
function AvengersController(dataservice) {
var vm = this;
vm.avengers = [];
vm.title = 'Avengers';
dataservice.getAvengers().then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
/* recommended */
function AvengersController(dataservice) {
var vm = this;
vm.avengers = [];
vm.title = 'Avengers';
activate();
////////////
function activate() {
return dataservice.getAvengers().then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
}
[Style Y081]
Why?: A controller may require data before it loads. That data may come
from a promise via a custom factory or $http. Using a route resolve allows
the promise to resolve before the controller logic executes, so it might take
action based on that data from the promise.
Why?: The code executes after the route and in the controllers activate
function. The View starts to load right away. Data binding kicks in when the
activate promise resolves. A busy animation can be shown during the view
transition (via ng-view or ui-view)
Note: The code executes before the route via a promise. Rejecting the
promise cancels the route. Resolve makes the new view wait for the route to
resolve. A busy animation can be shown before the resolve and through
the view transition. If you want to get to the View faster and do not require a
checkpoint to decide if you can get to the View, consider
the controller activate technique instead.
/* avoid */
angular
.module('app')
.controller('AvengersController', AvengersController);
function AvengersController(movieService) {
var vm = this;
// unresolved
vm.movies;
// resolved asynchronously
movieService.getMovies().then(function(response) {
vm.movies = response.movies;
});
}
/* better */
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html',
controller: 'AvengersController',
controllerAs: 'vm',
resolve: {
moviesPrepService: function(movieService) {
return movieService.getMovies();
}
}
});
}
// avengers.js
angular
.module('app')
.controller('AvengersController', AvengersController);
AvengersController.$inject = ['moviesPrepService'];
function AvengersController(moviesPrepService) {
var vm = this;
vm.movies = moviesPrepService.movies;
}
Note: The example below shows the route resolve points to a named
function, which is easier to debug and easier to handle dependency injection.
/* even better */
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html',
controller: 'AvengersController',
controllerAs: 'vm',
resolve: {
moviesPrepService: moviesPrepService
}
});
}
function moviesPrepService(movieService) {
return movieService.getMovies();
}
// avengers.js
angular
.module('app')
.controller('AvengersController', AvengersController);
AvengersController.$inject = ['moviesPrepService'];
function AvengersController(moviesPrepService) {
var vm = this;
vm.movies = moviesPrepService.movies;
}
Note: The code example's dependency on movieService is not minification
safe on its own. For details on how to make this code minification safe, see
the sections on dependency injection and on minification and annotation.
Back to top
[Style Y082]
The catch block of a promise must return a rejected promise to maintain the
exception in the promise chain.
Why?: If the catch block does not return a rejected promise, the caller of the
promise will not know an exception occurred. The caller's then will execute.
Thus, the user may never know what happened.
/* avoid */
function getCustomer(id) {
return $http.get('/api/customer/' + id)
.then(getCustomerComplete)
.catch(getCustomerFailed);
function getCustomerFailed(e) {
var newMessage = 'XHR Failed for getCustomer'
if (e.data && e.data.description) {
newMessage = newMessage + '\n' + e.data.description;
}
e.data.description = newMessage;
logger.error(newMessage);
// ***
// Notice there is no return of the rejected promise
// ***
}
}
/* recommended */
function getCustomer(id) {
return $http.get('/api/customer/' + id)
.then(getCustomerComplete)
.catch(getCustomerFailed);
function getCustomerFailed(e) {
var newMessage = 'XHR Failed for getCustomer'
if (e.data && e.data.description) {
newMessage = newMessage + '\n' + e.data.description;
}
e.data.description = newMessage;
logger.error(newMessage);
return $q.reject(e);
}
}
Back to top
[Style Y090]
Why?: The parameters to the component (e.g. controller, factory, etc) will be
converted to mangled variables. For example, common and dataservice may
become a or b and not be found by Angular.
/* avoid - not minification-safe*/
angular
.module('app')
.controller('DashboardController', DashboardController);
This code may produce mangled variables when minified and thus cause
runtime errors.
[Style Y091]
/* avoid */
angular
.module('app')
.controller('DashboardController',
['$location', '$routeParams', 'common', 'dataservice',
function Dashboard($location, $routeParams, common,
dataservice) {}
]);
/* avoid */
angular
.module('app')
.controller('DashboardController',
['$location', '$routeParams', 'common', 'dataservice', Dashboard]);
DashboardPanelController.$inject = ['logger'];
function DashboardPanelController(logger) {
}
[Style Y092]
Why?: This technique breaks out the anonymous function for the route
resolver, making it easier to read.
ng-annotate
[Style Y100]
Use ng-annotate for Gulp or Grunt and comment functions that need
automated dependency injection using /* @ngInject */
Why?: This safeguards your code from any dependencies that may not be
using minification-safe practices.
angular
.module('app')
.controller('AvengersController', AvengersController);
/* @ngInject */
function AvengersController(storage, avengerService) {
var vm = this;
vm.heroSearch = '';
vm.storeHero = storeHero;
function storeHero() {
var hero = avengerService.find(vm.heroSearch);
storage.save(hero.name, hero);
}
}
When the above code is run through ng-annotate it will produce the
following output with the $inject annotation and become minification-safe.
angular
.module('app')
.controller('AvengersController', AvengersController);
/* @ngInject */
function AvengersController(storage, avengerService) {
var vm = this;
vm.heroSearch = '';
vm.storeHero = storeHero;
function storeHero() {
var hero = avengerService.find(vm.heroSearch);
storage.save(hero.name, hero);
}
}
[Style Y101]
return gulp.src(source)
.pipe(sourcemaps.init())
.pipe(concat('all.min.js', {newLine: ';'}))
// Annotate before uglify so the code get's min'd properly.
.pipe(ngAnnotate({
// true helps add where @ngInject is not used. It infers.
// Doesn't work with resolve, so we must be explicit there
add: true
}))
.pipe(bytediff.start())
.pipe(uglify({mangle: true}))
.pipe(bytediff.stop())
.pipe(sourcemaps.write('./'))
.pipe(gulp.dest(pkg.paths.dev));
});
Back to top
Exception Handling
decorators
[Style Y110]
/* recommended */
angular
.module('blocks.exception')
.config(exceptionConfig);
exceptionConfig.$inject = ['$provide'];
function exceptionConfig($provide) {
$provide.decorator('$exceptionHandler', extendExceptionHandler);
}
Exception Catchers
[Style Y111]
Note: The exception catcher is good for catching and reacting to specific
exceptions from calls that you know may throw one. For example, when
making an XHR call to retrieve data from a remote web service and you want
to catch any exceptions from that service and react uniquely.
/* recommended */
angular
.module('blocks.exception')
.factory('exception', exception);
exception.$inject = ['logger'];
function exception(logger) {
var service = {
catcher: catcher
};
return service;
function catcher(message) {
return function(reason) {
logger.error(message, reason);
};
}
}
Route Errors
[Style Y112]
/* recommended */
var handlingRouteChangeError = false;
function handleRoutingErrors() {
/**
* Route cancellation:
* On routing error, go to the dashboard.
* Provide an exit clause if it tries to do it twice.
*/
$rootScope.$on('$routeChangeError',
function(event, current, previous, rejection) {
if (handlingRouteChangeError) { return; }
handlingRouteChangeError = true;
var destination = (current && (current.title ||
current.name || current.loadedTemplateUrl)) ||
'unknown target';
var msg = 'Error routing to ' + destination + '. ' +
(rejection.msg || '');
/**
* Optionally log using a custom service or $log.
* (Don't forget to inject custom service)
*/
logger.warning(msg, [current]);
/**
* On routing error, go to another route/state.
*/
$location.path('/');
}
);
}
Back to top
Naming
Naming Guidelines
[Style Y120]
Use consistent names for all components following a pattern that describes
the component's feature then (optionally) its type. My recommended
pattern is feature.type.js. There are 2 names for most assets:
o the file name (avengers.controller.js)
o the registered component name with Angular (AvengersController)
Why?: The naming conventions should simply help you find your code faster
and make it easier to understand.
[Style Y121]
Use consistent names for all components following a pattern that describes
the component's feature then (optionally) its type. My recommended
pattern is feature.type.js.
/**
* common options
*/
// Controllers
avengers.js
avengers.controller.js
avengersController.js
// Services/Factories
logger.js
logger.service.js
loggerService.js
/**
* recommended
*/
// controllers
avengers.controller.js
avengers.controller.spec.js
// services/factories
logger.service.js
logger.service.spec.js
// constants
constants.js
// module definition
avengers.module.js
// routes
avengers.routes.js
avengers.routes.spec.js
// configuration
avengers.config.js
// directives
avenger-profile.directive.js
avenger-profile.directive.spec.js
Note: Another common convention is naming controller files without the
word controller in the file name such as avengers.js instead
of avengers.controller.js. All other conventions still hold using a suffix of
the type. Controllers are the most common type of component so this just
saves typing and is still easily identifiable. I recommend you choose 1
convention and be consistent for your team. My preference
is avengers.controller.js identifying the AvengersController.
/**
* recommended
*/
// Controllers
avengers.js
avengers.spec.js
Name test specifications similar to the component they test with a suffix
of spec.
/**
* recommended
*/
avengers.controller.spec.js
logger.service.spec.js
avengers.routes.spec.js
avenger-profile.directive.spec.js
Controller Names
[Style Y123]
Use consistent names for all controllers named after their feature. Use
UpperCamelCase for controllers, as they are constructors.
/**
* recommended
*/
// avengers.controller.js
angular
.module
.controller('HeroAvengersController', HeroAvengersController);
function HeroAvengersController() { }
[Style Y124]
// avengers.controller.js
angular
.module
.controller('AvengersController', AvengersController);
function AvengersController() { }
[Style Y125]
Use consistent names for all factories and services named after their feature.
Use camel-casing for services and factories. Avoid prefixing factories and
services with $. Only suffix service and factories with Service when it is not
clear what they are (i.e. when they are nouns).
Why?: Avoids name collisions with built-in factories and services that use
the $ prefix.
Why?: Clear service names such as logger do not require a suffix.
Why?: Service names such as avengers are nouns and require a suffix and
should be named avengersService.
/**
* recommended
*/
// logger.service.js
angular
.module
.factory('logger', logger);
function logger() { }
/**
* recommended
*/
// credit.service.js
angular
.module
.factory('creditService', creditService);
function creditService() { }
// customer.service.js
angular
.module
.service('customerService', customerService);
function customerService() { }
[Style Y126]
Use consistent names for all directives using camel-case. Use a short prefix
to describe the area that the directives belong (some example are company
prefix or project prefix).
/**
* recommended
*/
// avenger-profile.directive.js
angular
.module
.directive('xxAvengerProfile', xxAvengerProfile);
function xxAvengerProfile() { }
Modules
[Style Y127]
Why?: Provides consistency for multiple module apps, and for expanding to
large applications.
Why?: Provides easy way to use task automation to load all module
definitions first, then all other angular files (for bundling).
Configuration
[Style Y128]
Separate configuration for a module into its own file named after the
module. A configuration file for the main appmodule is
named app.config.js (or simply config.js). A configuration for a module
named admin.module.js is named admin.config.js.
Routes
[Style Y129]
Separate route configuration into its own file. Examples might be app.route.js for
the main module and admin.route.js for the admin module. Even in smaller apps I
prefer this separation from the rest of the configuration.
Back to top
LIFT
[Style Y140]
Structure your app such that you can Locate your code quickly, Identify the
code at a glance, keep the Flattest structure you can, and Try to stay DRY.
The structure should follow these 4 basic guidelines.
Why LIFT?: Provides a consistent structure that scales well, is modular, and
makes it easier to increase developer efficiency by finding code quickly.
Another way to check your app structure is to ask yourself: How quickly can
you open and work in all of the related files for a feature?
When I find my structure is not feeling comfortable, I go back and revisit
these LIFT guidelines
Locate
[Style Y141]
Why?: I find this to be super important for a project. If the team cannot find
the files they need to work on quickly, they will not be able to work as
efficiently as possible, and the structure needs to change. You may not know
the file name or where its related files are, so putting them in the most
intuitive locations and near each other saves a ton of time. A descriptive
folder structure can help with this.
/bower_components
/client
/app
/avengers
/blocks
/exception
/logger
/core
/dashboard
/data
/layout
/widgets
/content
index.html
.bower.json
Identify
[Style Y142]
When you look at a file you should instantly know what it contains and
represents.
Why?: You spend less time hunting and pecking for code, and become more
efficient. If this means you want longer file names, then so be it. Be
descriptive with file names and keeping the contents of the file to exactly 1
component. Avoid files with multiple controllers, multiple services, or a
mixture. There are deviations of the 1 per file rule when I have a set of very
small features that are all related to each other, they are still easily
identifiable.
Flat
[Style Y143]
Keep a flat folder structure as long as possible. When you get to 7+ files,
begin considering separation.
Why?: Nobody wants to search 7 levels of folders to find a file. Think about
menus on web sites anything deeper than 2 should take serious
consideration. In a folder structure there is no hard and fast number rule,
but when a folder has 7-10 files, that may be time to create subfolders. Base
it on your comfort level. Use a flatter structure until there is an obvious value
(to help the rest of LIFT) in creating a new folder.
[Style Y144]
Why?: Being DRY is important, but not crucial if it sacrifices the others in LIFT,
which is why I call it T-DRY. I dont want to type session-view.html for a view
because, well, its obviously a view. If it is not obvious or by convention, then
I name it.
Back to top
Application Structure
Overall Guidelines
[Style Y150]
Have a near term view of implementation and a long term vision. In other
words, start small but keep in mind on where the app is heading down the
road. All of the app's code goes in a root folder named app. All content is 1
feature per file. Each controller, service, module, view is in its own file. All 3rd
party vendor scripts are stored in another root folder and not in
the app folder. I didn't write them and I don't want them cluttering my app
(bower_components, scripts, lib).
Note: Find more details and reasoning behind the structure at this original
post on application structure.
Layout
[Style Y151]
Place components that define the overall layout of the application in a folder
named layout. These may include a shell view and controller may act as the
container for the app, navigation, menus, content areas, and other regions.
Folders-by-Feature Structure
[Style Y152]
Create folders named for the feature they represent. When a folder grows to
contain more than 7 files, start to consider creating a folder for them. Your
threshold may be different, so adjust as needed.
Why?: A developer can locate the code, identify what each file represents at
a glance, the structure is flat as can be, and there is no repetitive nor
redundant names.
Why?: Helps reduce the app from becoming cluttered through organizing
the content and keeping them aligned with the LIFT guidelines.
Why?: When there are a lot of files (10+) locating them is easier with a
consistent folder structures and more difficult in flat structures.
/**
* recommended
*/
app/
app.module.js
app.config.js
components/
calendar.directive.js
calendar.directive.html
user-profile.directive.js
user-profile.directive.html
layout/
shell.html
shell.controller.js
topnav.html
topnav.controller.js
people/
attendees.html
attendees.controller.js
people.routes.js
speakers.html
speakers.controller.js
speaker-detail.html
speaker-detail.controller.js
services/
data.service.js
localstorage.service.js
logger.service.js
spinner.service.js
sessions/
sessions.html
sessions.controller.js
sessions.routes.js
session-detail.html
session-detail.controller.js
Note: Do not structure your app using folders-by-type. This requires moving
to multiple folders when working on a feature and gets unwieldy quickly as
the app grows to 5, 10 or 25+ views and controllers (and other features),
which makes it more difficult than folder-by-feature to locate files.
/*
* avoid
* Alternative folders-by-type.
* I recommend "folders-by-feature", instead.
*/
app/
app.module.js
app.config.js
app.routes.js
directives.js
controllers/
attendees.js
session-detail.js
sessions.js
shell.js
speakers.js
speaker-detail.js
topnav.js
directives/
calendar.directive.js
calendar.directive.html
user-profile.directive.js
user-profile.directive.html
services/
dataservice.js
localstorage.js
logger.js
spinner.js
views/
attendees.html
session-detail.html
sessions.html
shell.html
speakers.html
speaker-detail.html
topnav.html
Back to top
Modularity
[Style Y160]
Why?: Modular applications make it easy to plug and go as they allow the
development teams to build vertical slices of the applications and roll out
incrementally. This means we can plug in new features as we develop them.
[Style Y161]
Create an application root module whose role is to pull together all of the
modules and features of your application. Name this for your application.
[Style Y162]
Only put logic for pulling together the app in the application module. Leave
features in their own modules.
Why?: Adding additional roles to the application root to get remote data,
display views, or other logic not related to pulling the app together muddies
the app module and make both sets of features harder to reuse or turn off.
Why?: The app module becomes a manifest that describes which modules
help define the application.
[Style Y163]
Create modules that represent feature areas, such as layout, reusable and
shared services, dashboards, and app specific features (e.g. customers,
admin, sales).
Why?: Self contained modules can be added to the application with little or
no friction.
Why?: Sprints or iterations can focus on feature areas and turn them on at
the end of the sprint or iteration.
Why?: Separating feature areas into modules makes it easier to test the
modules in isolation and reuse code.
[Style Y164]
Module Dependencies
[Style Y165]
The application root module depends on the app specific feature modules
and any shared or reusable modules.
Why?: The main app module contains a quickly identifiable manifest of the
application's features.
Why?: Each feature area contains a manifest of what it depends on, so it can
be pulled in as a dependency in other applications and still work.
Why?: Intra-App features such as shared data services become easy to locate
and share from within app.core (choose your favorite name for this module).
Note: This is a strategy for consistency. There are many good options here.
Choose one that is consistent, follows Angular's dependency rules, and is
easy to maintain and scale.
My structures vary slightly between projects but they all follow these
guidelines for structure and modularity. The implementation may vary
depending on the features and the team. In other words, don't get hung up
on an exact like-for-like structure but do justify your structure using
consistency, maintainability, and efficiency in mind.
In a small app, you can also consider putting all the shared dependencies in
the app module where the feature modules have no direct dependencies.
This makes it easier to maintain the smaller application, but makes it harder
to reuse modules outside of this application.
Back to top
Startup Logic
Configuration
[Style Y170]
angular
.module('app')
.config(configure);
configure.$inject =
['routerHelperProvider', 'exceptionHandlerProvider', 'toastr'];
////////////////
function configureStateHelper() {
routerHelperProvider.configure({
docTitle: 'NG-Modular: '
});
}
}
Run Blocks
[Style Y171]
Any code that needs to run when an application starts should be declared in
a factory, exposed via a function, and injected into the run block.
Why?: Code directly in a run block can be difficult to test. Placing in a factory
makes it easier to abstract and mock.
angular
.module('app')
.run(runBlock);
[Style Y180]
[Style Y181]
Why?: These services are wrapped by Angular and more easily testable and
handle Angular's digest cycle thus keeping data binding in sync.
Back to top
Testing
Unit testing helps maintain clean code, as such I included some of my
recommendations for unit testing foundations with links for more information.
[Style Y190]
Write a set of tests for every story. Start with an empty test and fill them in
as you write the code for the story.
Why?: Writing the test descriptions helps clearly define what your story will
do, will not do, and how you can measure success.
// and so on
Testing Library
[Style Y191]
Why?: Both Jasmine and Mocha are widely used in the Angular community.
Both are stable, well maintained, and provide robust testing features.
Note: When using Mocha, also consider choosing an assert library such
as Chai. I prefer Mocha.
Test Runner
[Style Y192]
Why?: Karma hooks into your Continuous Integration process easily on its
own or through Grunt or Gulp.
/* recommended */
var karmaOptions = {
configFile: __dirname + '/karma.conf.js',
exclude: excludeFiles,
singleRun: !!singleRun
};
////////////////
function karmaCompleted(karmaResult) {
log('Karma completed');
if (child) {
log('shutting down the child process');
child.kill();
}
if (karmaResult === 1) {
done('karma: tests failed with code ' + karmaResult);
} else {
done();
}
}
}
[Style Y193]
Why?: Sinon works well with both Jasmine and Mocha and extends the
stubbing and spying features they offer.
Why?: Sinon makes it easier to toggle between Jasmine and Mocha, if you
want to try both.
Why?: Sinon has descriptive messages when tests fail the assertions.
Headless Browser
[Style Y194]
Why?: PhantomJS is a headless browser that helps run your tests without
needing a "visual" browser. So you do not have to install Chrome, Safari, IE,
or other browsers on your server.
Code Analysis
[Style Y195]
Why?: Tests are code. JSHint can help identify code quality issues that may
cause the test to work improperly.
[Style Y196]
Relax the rules on your test code to allow for common globals such
as describe and expect. Relax the rules for expressions, as Mocha uses these.
Why?: Your tests are code and require the same attention and code quality
rules as all of your production code. However, global variables used by the
testing framework, for example, can be relaxed by including this in your test
specs.
"jasmine": true,
"mocha": true,
Organizing Tests
[Style Y197]
Place unit test files (specs) side-by-side with your client code. Place specs
that cover server integration or test multiple components in a
separate tests folder.
Why?: Unit tests have a direct correlation to a specific component and file in
source code.
Why?: It is easier to keep them up to date since they are always in sight.
When coding whether you do TDD or test during development or test after
development, the specs are side-by-side and never out of sight nor mind,
and thus more likely to be maintained which also helps maintain code
coverage.
Why?: When you update source code it is easier to go update the tests at
the same time.
Why?: Placing them side-by-side makes it easy to find them and easy to
move them with the source code if you move the source.
Why?: Having the spec nearby makes it easier for the source code reader to
learn how the component is supposed to be used and to discover its known
limitations.
Why?: Separating specs so they are not in a distributed build is easy with
grunt or gulp.
/src/client/app/customers/customer-detail.controller.js
/customer-detail.controller.spec.js
/customers.controller.js
/customers.controller.spec.js
/customers.module.js
/customers.route.js
/customers.route.spec.js
Back to top
Animations
Usage
[Style Y210]
Use subtle animations with Angular to transition between states for views
and primary visual elements. Include the ngAnimate module. The 3 keys are
subtle, smooth, seamless.
Sub Second
[Style Y211]
Use short durations for animations. I generally start with 300ms and adjust
until appropriate.
Why?: Long animations can have the reverse effect on User Experience and
perceived performance by giving the appearance of a slow application.
animate.css
[Style Y212]
Why?: The animations that animate.css provides are fast, smooth, and easy
to add to your application.
Back to top
Comments
jsDoc
[Style Y220]
Why?: You can generate (and regenerate) documentation from your code,
instead of writing it from scratch.
/**
* Logger Factory
* @namespace Factories
*/
(function() {
angular
.module('app')
.factory('logger', logger);
/**
* @namespace Logger
* @desc Application wide logger
* @memberOf Factories
*/
function logger($log) {
var service = {
logError: logError
};
return service;
////////////
/**
* @name logError
* @desc Logs errors
* @param {String} msg Message to log
* @returns {String}
* @memberOf Factories.Logger
*/
function logError(msg) {
var loggedMsg = 'Error: ' + msg;
$log.error(loggedMsg);
return loggedMsg;
};
}
})();
Back to top
JS Hint
[Style Y230]
Use JS Hint for linting your JavaScript and be sure to customize the JS Hint
options file and include in source control. See the JS Hint docs for details on
the options.
Why?: Provides a first alert prior to committing any code to source control.
{
"bitwise": true,
"camelcase": true,
"curly": true,
"eqeqeq": true,
"esversion": 6,
"forin": true,
"freeze": true,
"immed": true,
"indent": 4,
"latedef": "nofunc",
"newcap": true,
"noarg": true,
"noempty": true,
"nonbsp": true,
"nonew": true,
"plusplus": false,
"quotmark": "single",
"undef": true,
"unused": false,
"strict": false,
"maxparams": 10,
"maxdepth": 5,
"maxstatements": 40,
"maxcomplexity": 8,
"maxlen": 120,
"asi": false,
"boss": false,
"debug": false,
"eqnull": true,
"esnext": false,
"evil": false,
"expr": false,
"funcscope": false,
"globalstrict": false,
"iterator": false,
"lastsemic": false,
"laxbreak": false,
"laxcomma": false,
"loopfunc": true,
"maxerr": 50,
"moz": false,
"multistr": false,
"notypeof": false,
"proto": false,
"scripturl": false,
"shadow": false,
"sub": true,
"supernew": false,
"validthis": false,
"noyield": false,
"browser": true,
"node": true,
"globals": {
"angular": false,
"$": false
}
}
Back to top
JSCS
[Style Y235]
Use JSCS for checking your coding styles your JavaScript and be sure to
customize the JSCS options file and include in source control. See the JSCS
docs for details on the options.
Why?: Provides a first alert prior to committing any code to source control.
{
"excludeFiles": ["node_modules/**", "bower_components/**"],
"requireCurlyBraces": [
"if",
"else",
"for",
"while",
"do",
"try",
"catch"
],
"requireOperatorBeforeLineBreak": true,
"requireCamelCaseOrUpperCaseIdentifiers": true,
"maximumLineLength": {
"value": 100,
"allowComments": true,
"allowRegex": true
},
"validateIndentation": 4,
"validateQuoteMarks": "'",
"disallowMultipleLineStrings": true,
"disallowMixedSpacesAndTabs": true,
"disallowTrailingWhitespace": true,
"disallowSpaceAfterPrefixUnaryOperators": true,
"disallowMultipleVarDecl": null,
"requireSpaceAfterKeywords": [
"if",
"else",
"for",
"while",
"do",
"switch",
"return",
"try",
"catch"
],
"requireSpaceBeforeBinaryOperators": [
"=", "+=", "-=", "*=", "/=", "%=", "<<=", ">>=", ">>>=",
"&=", "|=", "^=", "+=",
"jsDoc": {
"checkAnnotations": true,
"checkParamNames": true,
"requireParamTypes": true,
"checkReturnTypes": true,
"checkTypes": true
},
"disallowMultipleLineBreaks": true,
"disallowCommaBeforeLineBreak": null,
"disallowDanglingUnderscores": null,
"disallowEmptyBlocks": null,
"disallowTrailingComma": null,
"requireCommaBeforeLineBreak": null,
"requireDotNotation": null,
"requireMultipleVarDecl": null,
"requireParenthesesAroundIIFE": true
}
Back to top
Constants
Vendor Globals
[Style Y240]
// constants.js
angular
.module('app.core')
.constant('toastr', toastr)
.constant('moment', moment);
})();
[Style Y241]
Use constants for values that do not change and do not come from another
service. When constants are used only for a module that may be reused in
multiple applications, place constants in a file per module named after the
module. Until this is required, keep constants in the main module in
a constants.js file.
Why?: A value that may change, even infrequently, should be retrieved from
a service so you do not have to change the source code. For example, a url
for a data service could be placed in a constants but a better place would be
to load it from a web service.
Sublime Text
[Style Y250]
Visual Studio
[Style Y251]
Angular file templates that follow these styles and guidelines can be found
at SideWaffle
WebStorm
[Style Y252]
Individual templates are also available for download within the webstorm-
angular-live-templates folder
Atom
[Style Y253]
or
o Open Atom, then open the Package Manager (Packages -> Settings View ->
Install Packages/Themes)
o Search for the package 'angularjs-styleguide-snippets'
o Click 'Install' to install the package
In a JavaScript file type these commands followed by a TAB
ngcontroller // creates an Angular controller
ngdirective // creates an Angular directive
ngfactory // creates an Angular factory
ngmodule // creates an Angular module
ngservice // creates an Angular service
ngfilter // creates an Angular filter
Brackets
[Style Y254]
vim
[Style Y255]
[Style Y256]
Visual Studio Code snippets that follow these styles and guidelines.
Emacs
[Style Y257]
[Style Y260]
You can use the HotTowel yeoman generator to create an app that serves as a
starting point for Angular that follows this style guide.
1. Install generator-hottowel
4. mkdir myapp
5. cd myapp
7. yo hottowel helloWorld
Back to top
Routing
Client-side routing is important for creating a navigation flow between views and
composing views that are made of many smaller templates and directives.
[Style Y270]
Why?: UI Router offers all the features of the Angular router plus a few
additional ones including nested routes and states.
Why?: The syntax is quite similar to the Angular router and is easy to migrate
to UI Router.
Note: You can use a provider such as the routerHelperProvider shown below
to help configure states across files, during the run phase.
// customers.routes.js
angular
.module('app.customers')
.run(appRun);
/* @ngInject */
function appRun(routerHelper) {
routerHelper.configureStates(getStates());
}
function getStates() {
return [
{
state: 'customer',
config: {
abstract: true,
template: '<ui-view class="shuffle-animation"/>',
url: '/customer'
}
}
];
}
// routerHelperProvider.js
angular
.module('blocks.router')
.provider('routerHelper', routerHelperProvider);
$locationProvider.html5Mode(true);
RouterHelper.$inject = ['$state'];
/* @ngInject */
function RouterHelper($state) {
var hasOtherwise = false;
var service = {
configureStates: configureStates,
getStates: getStates
};
return service;
///////////////
[Style Y271]
Define routes for views in the module where they exist. Each module should
contain the routes for the views in the module.
Why?: When removing a module or adding a module, the app will only
contain routes that point to existing views.
Back to top
Task Automation
Use Gulp or Grunt for creating automated tasks. Gulp leans to code over
configuration while Grunt leans to configuration over code. I personally prefer Gulp
as I feel it is easier to read and write, but both are excellent.
Learn more about gulp and patterns for task automation in my Gulp Pluralsight
course
[Style Y400]
Use task automation to list module definition files *.module.js before all
other application JavaScript files.
Why?: Angular needs the module definitions to be registered before they are
used.
Filters
[Style Y420]
Avoid using filters for scanning all properties of a complex object graph. Use
filters for select properties.
Why?: Filters can easily be abused and negatively affect performance if not
used wisely, for example when a filter hits a large and deep object graph.
Back to top
Angular docs
For anything else, API reference, check the Angular documentation.
Back to top
Single Responsibility o Responsabilidad nica
La regla del 1
[Style Y001]
Por qu?: Un componente por archivo hace que sea mucho ms fcil de leer,
mantener, y evita colisiones con los equipos en el control de cdigo.
Por qu?: Un componente por archivo evita errores ocultos que a menudo
surgen cuando se combinan componentes en un archivo donde pueden
compartir variables, crear closures (clausuras) no deseadas, o acoplamiento
indeseado de dependencias.
function SomeController() { }
function someFactory() { }
/* recomendado */
// app.module.js
angular
.module('app', ['ngRoute']);
/* recomendado */
// someController.js
angular
.module('app')
.controller('SomeController', SomeController);
function SomeController() { }
/* recomendado */
// someFactory.js
angular
.module('app')
.factory('someFactory', someFactory);
function someFactory() { }
Volver arriba
IIFE
Closures de JavaScript
[Style Y010]
Por qu?: Una IIFE elimina las variables del scope global. Esto ayuda a
prevenir que las variables y las declaraciones de funciones vivan ms de lo
esperado en el scope global, evitando as colisin de variables.
/* evitar */
// logger.js
angular
.module('app')
.factory('logger', logger);
// storage.js
angular
.module('app')
.factory('storage', storage);
// logger.js
(function() {
'use strict';
angular
.module('app')
.factory('logger', logger);
function logger() { }
})();
// storage.js
(function() {
'use strict';
angular
.module('app')
.factory('storage', storage);
function storage() { }
})();
Nota: Para acortar nicamente, el resto de los ejemplos de esta gua podran
omitir la sintaxis IIFE.
Nota: IIFE previente que el cdigo de los tests llegue a sus variables privadas,
como expresiones regulares o funciones de ayuda que normalmente vienen
bien para hacer pruebas por s solas. Sin embargo, puedes acceder a ellas
creando accesorios o accediendo a travs de sus componentes. Por ejemplo,
poniendo las funciones de ayuda, expresiones regulares o constantes en su
propia fbrica.
Volver arriba
Mdulos
[Style Y020]
Use una convencin de nombres nica con separadores para los sub-
mdulos.
Por qu?: Nombres nicos ayudan a evitar colisiones en los nombres de
mdulos. Los separadores ayudan a definir los mdulos y la jerarqua de sus
sub-mdulos. Por ejemplo app puede ser tu mdulo raz
y app.dashboard y app.userspueden ser mdulos que dependen de app.
[Style Y021]
Declara los mdulos sin usar una variable, usando la sintaxis de los setters.
/* evitar */
var app = angular.module('app', [
'ngAnimate',
'ngRoute',
'app.shared',
'app.dashboard'
]);
/* recomendado */
angular
.module('app', [
'ngAnimate',
'ngRoute',
'app.shared',
'app.dashboard'
]);
Getters
[Style Y022]
Por qu?: Esto hace ms legible el cdigo y evita que las variables
colisionen.
/* evitar */
var app = angular.module('app');
app.controller('SomeController', SomeController);
function SomeController() { }
/* recomendado */
angular
.module('app')
.controller('SomeController', SomeController);
function SomeController() { }
Setting vs Getting
[Style Y023]
Por qu?: Un mdulo debe ser creado slo una vez y recuperado desde ese
punto.
[Style Y024]
/* evitar */
angular
.module('app')
.controller('Dashboard', function() { })
.factory('logger', function() { });
/* recomendado */
// dashboard.js
angular
.module('app')
.controller('Dashboard', Dashboard);
function Dashboard() { }
// logger.js
angular
.module('app')
.factory('logger', logger);
function logger() { }
Volver arriba
Controladores
[Style Y030]
[Style Y031]
controllerAs con vm
[Style Y032]
Usa una variable para capturar this cuando uses la sintaxis controllerAs.
Elige un nombre de variable consistente como vm, de ViewModel.
Por qu?: La palabra this es contextual y cuando es usada dentro de una
funcin en un controlador puede cambiar su contexto. Capturando el
contexto de this te evita encontrarte este problema.
/* evitar */
function Customer() {
this.name = {};
this.sendMessage = function() { };
}
/* recomendado */
function Customer() {
var vm = this;
vm.name = {};
vm.sendMessage = function() { };
}
[Style Y033]
Por qu?: Colocar las variables asignables arriba hace ms fcil la lectura y
te ayuda a identificar qu variables del controlador pueden ser asociadas y
usadas en la Vista.
Por qu?: Setear funciones annimas puede ser fcil, pero cuando esas
funciones tienen ms de una lnea de cdigo se hace menos legible. Definir
las funciones bajo las variables bindeables (las declaraciones de las
funciones sern movidas hacia arriba en el proceso de hoisting), hace que
los detalles de implementacin estn abajo, deja las variables arriba y ms
sencilla la lectura.
/* evitar */
function Sessions() {
var vm = this;
vm.gotoSession = function() {
/* ... */
};
vm.refresh = function() {
/* ... */
};
vm.search = function() {
/* ... */
};
vm.sessions = [];
vm.title = 'Sessions';
/* recomendado */
function Sessions() {
var vm = this;
vm.gotoSession = gotoSession;
vm.refresh = refresh;
vm.search = search;
vm.sessions = [];
vm.title = 'Sessions';
////////////
function gotoSession() {
/* */
}
function refresh() {
/* */
}
function search() {
/* */
}
/* evitar */
function Sessions(data) {
var vm = this;
vm.gotoSession = gotoSession;
vm.refresh = function() {
/**
* lneas
* de
* cdigo
* que afectan a
* la legibilidad
*/
};
vm.search = search;
vm.sessions = [];
vm.title = 'Sessions';
/* recomendado */
function Sessions(dataservice) {
var vm = this;
vm.gotoSession = gotoSession;
vm.refresh = dataservice.refresh; // 1 liner is OK
vm.search = search;
vm.sessions = [];
vm.title = 'Sessions';
[Style Y034]
Por qu?: Colocar las variables bindeables arriba hace ms fcil la lectura y
te ayuda a identificar qu variables del controlador pueden ser asociadas y
usadas en la Vista.
Por qu?: Colocar los detalles de implementacin de una funcin al final del
archivo deja la complejidad fuera de vista as puedes ver las cosas
importantes arriba.
Por qu?: La declaracin de las funciones son movidas arriba por el proceso
de hoisting as que no tenemos que preocuparnos por usar una funcin
antes de que sea definida (como la habra si fueran funciones en forma de
expresin)
Por qu?: No tendrs que preocuparte de que si pones var a antes de var
b se rompa el cdigo porque a dependa de b.
/**
* evitar
* Using function expressions.
*/
function Avengers(dataservice, logger) {
var vm = this;
vm.avengers = [];
vm.title = 'Avengers';
vm.getAvengers = getAvengers;
activate();
}
Ntese que las cosas importantes estn dispersas en el ejemplo anterior. En
el siguiente ejemplo, lo importante est arriba. Por ejemplo, las variables
asociadas al controlador como vm.avengers y vm.title. Los detalles de
implementacin estn debajo. As es ms fcil de leer.
/*
* recomendado
* Usando declaraciones de funciones y
* miembros bindeables arriba.
*/
function Avengers(dataservice, logger) {
var vm = this;
vm.avengers = [];
vm.getAvengers = getAvengers;
vm.title = 'Avengers';
activate();
function activate() {
return getAvengers().then(function() {
logger.info('Activated Avengers View');
});
}
function getAvengers() {
return dataservice.getAvengers().then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
}
[Style Y035]
Por qu?: La lgica podra ser reutilizada por varios controladores cuando la
colocas en un servicio y la expones como una funcin.
/* evitar */
function Order($http, $q, config, userInfo) {
var vm = this;
vm.checkCredit = checkCredit;
vm.isCreditOk;
vm.total = 0;
function checkCredit() {
var settings = {};
// Get the credit service base URL from config
// Set credit service required headers
// Prepare URL query string or data object with request data
// Add user-identifying info so service gets the right credit
limit for this user.
// Use JSONP for this browser if it doesn't support CORS
return $http.get(settings)
.then(function(data) {
// Unpack JSON data in the response object
// to find maxRemainingAmount
vm.isCreditOk = vm.total <= maxRemainingAmount
})
.catch(function(error) {
// Interpret error
// Cope w/ timeout? retry? try alternate service?
// Re-reject with appropriate error for a user to see
});
};
}
/* recomendado */
function Order(creditService) {
var vm = this;
vm.checkCredit = checkCredit;
vm.isCreditOk;
vm.total = 0;
function checkCredit() {
return creditService.isOrderTotalOk(vm.total)
.then(function(isOk) { vm.isCreditOk = isOk; })
.catch(showServiceError);
};
}
[Style Y037]
Asignando Controladores
[Style Y038]
Nota: Si una Vista es cargada por otra adems de por la ruta, entonces usa
la sintaxis ng-controller="Avengers as vm".
Por qu?: Emparejar el controlador en la ruta permite a diferentes rutas
invocar diferentes pares de controladores y vistas. Cuando los controladores
son asignados en la vista usando ng-controller, esa vista siempre estar
asociada al mismo controlador.
/* evitar - cuando se use con una ruta y queramos asociarlo dinmicamente
*/
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html'
});
}
<!-- avengers.html -->
<div ng-controller="Avengers as vm">
</div>
/* recomendado */
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html',
controller: 'Avengers',
controllerAs: 'vm'
});
}
<!-- avengers.html -->
<div>
</div>
Volver arriba
Servicios
Singletons
[Style Y040]
Los Servicios son instanciados con un new, usan this para los mtodos
pblicos y las variables. Ya que son muy similares a las factories, usa una
factory en su lugar por consistencia.
Nota: Todos los servicios Angular son singletons. Esto significa que slo hay
una instancia de un servicio por inyector.
// service
angular
.module('app')
.service('logger', logger);
function logger() {
this.logError = function(msg) {
/* */
};
}
// factory
angular
.module('app')
.factory('logger', logger);
function logger() {
return {
logError: function(msg) {
/* */
}
};
}
Volver arriba
Fbricas
Responsabilidad nica
[Style Y050]
Las fbricas deben tener una responsabilidad nica, que es encapsulada por su
contexto. Cuando una fbrica empiece a exceder el principio de responsabilidad
nica, una nueva fbrica debe ser creada.
Singletons
[Style Y051]
Las Fbricas son singleton y devuelven un objeto que contiene las variables
del servicio.
Expn las variables que se llaman del servicio (su interfaz) arriba, usando la
tcnica deribada de Revealing Module Pattern.
Por qu?: Colocar los elementos que se llaman arriba hace ms fcil la
lectura y te ayuda a identificar los elementos del servicio que se pueden
llamar y se deben testear (y/o mockear).
Por qu?: Setear las funciones puede ser fcil, pero cuando tienen ms de
una lnea ser reduce la legibilidad. Definiendo la interfaz mueve los detalles
de implementacin abajo, mantiene la interfaz que va a ser llamada arriba y
lo hace ms fcil de leer.
/* evitar */
function dataService() {
var someValue = '';
function save() {
/* */
};
function validate() {
/* */
};
return {
save: save,
someValue: someValue,
validate: validate
};
}
/* recomendado */
function dataService() {
var someValue = '';
var service = {
save: save,
someValue: someValue,
validate: validate
};
return service;
////////////
function save() {
/* */
};
function validate() {
/* */
};
}
De esta forma se asocian los bindeos desde el objeto que lo mantiene, los
valores primitivos no se pueden modificar por si solos usando este patrn
Por qu?: Coloca los elementos accesibles en la parte superior para hacerlo
ms fcil de leer y ayudarte a identificar instantneamente qu funciones de
la fbrica se pueden accesar externamente.
Por qu?: Colocar los detalles de implementacin de una funcin al final del
archivo mueve esa complejidad fuera de la vista, de esta forma puedes dejar
lo importante arriba.
Por qu?: Las declaraciones de las funciones son "elevadas" de esta forma
no hay problemas en usar una funcin antes de su definicin (como la
habra si fueran funciones en forma de expresin).
Por qu?: No tendrs que preocuparte de que si pones var a antes de var
b se rompa el cdigo porque a dependa de b.
/**
* evitar
* Usar funcin como expresin
*/
function dataservice($http, $location, $q, exception, logger) {
var isPrimed = false;
var primePromise;
var service = {
getAvengersCast: getAvengersCast,
getAvengerCount: getAvengerCount,
getAvengers: getAvengers,
ready: ready
};
return service;
}
/**
* recomendado
* Usar declaracin de funciones
* y miembros accesibles arriba
*/
function dataservice($http, $location, $q, exception, logger) {
var isPrimed = false;
var primePromise;
var service = {
getAvengersCast: getAvengersCast,
getAvengerCount: getAvengerCount,
getAvengers: getAvengers,
ready: ready
};
return service;
////////////
function getAvengers() {
// detalles de implementacin van aqu
}
function getAvengerCount() {
// detalles de implementacin van aqu
}
function getAvengersCast() {
// detalles de implementacin van aqu
}
function prime() {
// detalles de implementacin van aqu
}
function ready(nextPromises) {
// detalles de implementacin van aqu
}
}
Volver arriba
Servicios de Datos
[Style Y060]
Por qu?: Hace ms fcil testear (mock o real) las llamadas de datos cuando
testeamos un controlador que usa un data service.
Por qu?: La implementacin del servicio de datos puede tener cdigo muy
especfico para usar el repositorio de datos. Podra incluir cabeceras, cmo
hablar a los datos, u otros servicios como $http. Separando la lgica en
servicios de datos encapsulamos la lgica en un nico lugar, escondiendo la
implementacin de sus consumidores externos (quiz un controlador), de
esta forma es ms fcil cambiar la implementacin.
/* recomendado */
// dataservice factory
angular
.module('app.core')
.factory('dataservice', dataservice);
function getAvengers() {
return $http.get('/api/maa')
.then(getAvengersComplete)
.catch(getAvengersFailed);
function getAvengersComplete(response) {
return response.data.results;
}
function getAvengersFailed(error) {
logger.error('XHR Failed for getAvengers.' + error.data);
}
}
}
/* recomendado */
activate();
function activate() {
return getAvengers().then(function() {
logger.info('Activated Avengers View');
});
}
function getAvengers() {
return dataservice.getAvengers()
.then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
}
[Style Y061]
/* recomendado */
activate();
function activate() {
/**
* Step 1
* Pide a la funcin getAvengers por los datos
* de los vengadores y espera la promesa
*/
return getAvengers().then(function() {
/**
* Step 4
* Ejecuta una accin cuando se resuelva la promesa final
*/
logger.info('Activated Avengers View');
});
}
function getAvengers() {
/**
* Step 2
* Pide al servicio de datos los datos y espera
* por la promesa
*/
return dataservice.getAvengers()
.then(function(data) {
/**
* Step 3
* setea los datos y resuelve la promesa
*/
vm.avengers = data;
return vm.avengers;
});
}
Volver arriba
Directivas
[Style Y070]
/* evitar */
/* directives.js */
angular
.module('app.widgets')
function orderCalendarRange() {
/* detalles de implementacin */
}
function salesCustomerInfo() {
/* detalles de implementacin */
}
function sharedSpinner() {
/* detalles de implementacin */
}
/* recomendado */
/* calendarRange.directive.js */
/**
* @desc directiva de rdenes que es especfica al mdulo de rdenes en la
compaa Acme
* @example <div acme-order-calendar-range></div>
*/
angular
.module('sales.order')
.directive('acmeOrderCalendarRange', orderCalendarRange);
function orderCalendarRange() {
/* detalles de implementacin */
}
/* recomendado */
/* customerInfo.directive.js */
/**
* @desc directiva de ventas que puede ser usada a lo largo de la
aplicacin de ventas en la compaa Acme
* @example <div acme-sales-customer-info></div>
*/
angular
.module('sales.widgets')
.directive('acmeSalesCustomerInfo', salesCustomerInfo);
function salesCustomerInfo() {
/* detalles de implementacin */
}
/* recomendado */
/* spinner.directive.js */
/**
* @desc directiva de spinner que puede ser usada a lo largo de las
aplicaciones en la compaa Acme
* @example <div acme-shared-spinner></div>
*/
angular
.module('shared.widgets')
.directive('acmeSharedSpinner', sharedSpinner);
function sharedSpinner() {
/* detalles de implementacin */
}
[Style Y072]
[Style Y074]
Por qu?: Mientras permitamos que una directiva sea usada como una clase,
si esa directiva realmente est actuando como un elemento, tiene sentido
que sea un elemento, o al menos un atributo.
function myCalendarRange() {
var directive = {
link: link,
templateUrl: '/template/is/located/here.html',
restrict: 'C'
};
return directive;
function myCalendarRange() {
var directive = {
link: link,
templateUrl: '/template/is/located/here.html',
restrict: 'EA'
};
return directive;
Directivas y ControllerAs
[Style Y075]
Usa la sintaxis controller as con una directiva para ser consistente con el
uso de controller as con los pares de vista y controlador.
function myExample() {
var directive = {
restrict: 'EA',
templateUrl: 'app/feature/example.directive.html',
scope: {
max: '='
},
link: linkFunc,
controller: ExampleController,
controllerAs: 'vm',
bindToController: true // porque el scope is aislado
};
return directive;
ExampleController.$inject = ['$scope'];
function ExampleController($scope) {
// Inyectando el $scope solo para comparacin
var vm = this;
vm.min = 3;
[Style Y076]
function myExample() {
var directive = {
restrict: 'EA',
templateUrl: 'app/feature/example.directive.html',
scope: {
max: '='
},
controller: ExampleController,
controllerAs: 'vm',
bindToController: true
};
return directive;
}
function ExampleController() {
var vm = this;
vm.min = 3;
console.log('CTRL: vm.min = %s', vm.min);
console.log('CTRL: vm.max = %s', vm.max);
}
<!-- example.directive.html -->
<div>hello world</div>
<div>max={{vm.max}}<input ng-model="vm.max"/></div>
<div>min={{vm.min}}<input ng-model="vm.min"/></div>
Volver arriba
[Style Y080]
Por qu?: El activate del controlador hace que la lgica para refrescar el
controlador/Vista sea reutilizable, mantiene la lgica junta, lleva el usuario a
la Vista ms rpido, hace las animaciones ms fciles en ng-view o ui-view y
lo hace ms rpido a la vista del usuario.
/* evitar */
function Avengers(dataservice) {
var vm = this;
vm.avengers = [];
vm.title = 'Avengers';
dataservice.getAvengers().then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
/* recomendado */
function Avengers(dataservice) {
var vm = this;
vm.avengers = [];
vm.title = 'Avengers';
activate();
////////////
function activate() {
return dataservice.getAvengers().then(function(data) {
vm.avengers = data;
return vm.avengers;
});
}
}
[Style Y081]
Por qu?: Un controlador puede requerir datos antes de que se cargue. Esos
datos deben venir desde una promesa a travs de una fbrica o de $http.
Usando un route resolve permite que la promesa se resuelva antes de que la
lgica del controlador se ejecute, as puedes tomar decisiones basndote en
los datos de la promesa.
function Avengers(movieService) {
var vm = this;
// sin resolver
vm.movies;
// resulta asincronamente
movieService.getMovies().then(function(response) {
vm.movies = response.movies;
});
}
/* better */
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html',
controller: 'Avengers',
controllerAs: 'vm',
resolve: {
moviesPrepService: function(movieService) {
return movieService.getMovies();
}
}
});
}
// avengers.js
angular
.module('app')
.controller('Avengers', Avengers);
Avengers.$inject = ['moviesPrepService'];
function Avengers(moviesPrepService) {
var vm = this;
vm.movies = moviesPrepService.movies;
}
Nota: El siguiente ejemplo muestra una ruta que cuando se resuelve apunta
a una funcin, hacindolo ms fcil de debugear y ms fcil de manejar la
inyeccin de dependencias.
/* even better */
// route-config.js
angular
.module('app')
.config(config);
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html',
controller: 'Avengers',
controllerAs: 'vm',
resolve: {
moviesPrepService: moviesPrepService
}
});
}
function moviePrepService(movieService) {
return movieService.getMovies();
}
// avengers.js
angular
.module('app')
.controller('Avengers', Avengers);
Avengers.$inject = ['moviesPrepService'];
function Avengers(moviesPrepService) {
var vm = this;
vm.movies = moviesPrepService.movies;
}
Nota: El cdigo del ejemplo de dependencia en movieService no se puede
minimizar tal cual. Para detalles en cmo hacer este cdigo sea minimizable,
mira la seccin en inyeccin de dependencias y en minimizacin y anotacin.
Volver arriba
[Style Y090]
Evita usar la sintaxis acortada para declarar dependencias sin usar algn
mtodo que permita minificacin.
[Style Y091]
Por qu?: Evita crear dependencias en lnea, ya que las listas largas pueden
ser difcil de leer en el arreglo. Tambin puede ser confuso que el arreglo
sea una serie de cadenas mientras que el ltimo componente es una funcin.
/* evitar */
angular
.module('app')
.controller('Dashboard',
['$location', '$routeParams', 'common', 'dataservice',
function Dashboard($location, $routeParams, common,
dataservice) {}
]);
/* evitar */
angular
.module('app')
.controller('Dashboard',
['$location', '$routeParams', 'common', 'dataservice', Dashboard]);
function DashboardPanel(logger) {
}
}
[Style Y092]
Por qu?: Esta tcnica separa la funcin annima para el route resolver,
haciendola ms fcil de leer.
Por qu?: Una declaracin $inject puede ser fcilmente preceder al route
resolver para hacer cualquier minificacin de dependencias segura.
/* recomendado */
function config($routeProvider) {
$routeProvider
.when('/avengers', {
templateUrl: 'avengers.html',
controller: 'Avengers',
controllerAs: 'vm',
resolve: {
moviesPrepService: moviePrepService
}
});
}
moviePrepService.$inject = ['movieService'];
function moviePrepService(movieService) {
return movieService.getMovies();
}
Volver arriba
Minificacin y Anotacin
ng-annotate
[Style Y100]
angular
.module('app')
.controller('Avengers', Avengers);
/* @ngInject */
function Avengers(storageService, avengerService) {
var vm = this;
vm.heroSearch = '';
vm.storeHero = storeHero;
function storeHero() {
var hero = avengerService.find(vm.heroSearch);
storageService.save(hero.name, hero);
}
}
Cuando el cdigo de arriba es ejecutado a travs de ng-annotate producir
la siguiente salida con la anotacin $injecty ser seguro para ser minificado.
angular
.module('app')
.controller('Avengers', Avengers);
/* @ngInject */
function Avengers(storageService, avengerService) {
var vm = this;
vm.heroSearch = '';
vm.storeHero = storeHero;
function storeHero() {
var hero = avengerService.find(vm.heroSearch);
storageService.save(hero.name, hero);
}
}
[Style Y101]
Manejo de Excepciones
Decoradores
[Style Y110]
/* recomendado */
angular
.module('blocks.exception')
.config(exceptionConfig);
exceptionConfig.$inject = ['$provide'];
function exceptionConfig($provide) {
$provide.decorator('$exceptionHandler', extendExceptionHandler);
}
Cachadores de Excepciones
[Style Y111]
Crea una fbrica que exponga una interfaz para cachar y manejar
excepciones elegantemente.
/* recomendado */
angular
.module('blocks.exception')
.factory('exception', exception);
exception.$inject = ['logger'];
function exception(logger) {
var service = {
catcher: catcher
};
return service;
function catcher(message) {
return function(reason) {
logger.error(message, reason);
};
}
}
Errores de Ruta
[Style Y112]
Por qu?: Provee una manera consistente de manejar todos los errores de
enrutamiento.
/* recomendado */
function handleRoutingErrors() {
/**
* Route cancellation:
* Cancelacin de la Ruta:
* En un error de ruteo, ir al dashboard.
* Proveer una clusula de salida si trata de hacerlo dos veces.
*/
$rootScope.$on('$routeChangeError',
function(event, current, previous, rejection) {
var destination = (current && (current.title || current.name
|| current.loadedTemplateUrl)) ||
'unknown target';
var msg = 'Error routing to ' + destination + '. ' +
(rejection.msg || '');
/**
* Optionally log using a custom service or $log.
* Opcionalmente logear usando un servicio personalizado o
$log.
* (Don't forget to inject custom service)
*/
logger.warning(msg, [current]);
}
);
}
Volver arriba
Cmo Nombrar
Pautas para nombrar
[Style Y120]
Por qu?: Las pautas de como nombrar nos ayudan a proveer una manera
consistente para encontrar contenido en un vistazo. La Consistencia es vital
dentro del proyecto. La Consistencia es importante dentro de un equipo. La
Consistencia a lo largo de una compaa provee de una tremenda eficacia.
[Style Y121]
/**
* opciones comunes
*/
// Controladores
avengers.js
avengers.controller.js
avengersController.js
// Servicios/Factories
logger.js
logger.service.js
loggerService.js
/**
* recomendado
*/
// controllers
avengers.controller.js
avengers.controller.spec.js
// servicios/factories
logger.service.js
logger.service.spec.js
// constantes
constants.js
// definicin de mdulos
avengers.module.js
// rutas
avengers.routes.js
avengers.routes.spec.js
// configuracin
avengers.config.js
// directivas
avenger-profile.directive.js
avenger-profile.directive.spec.js
Nota: Otra convencin comn es nombrar archivos de controladores sin la
palabra controller en el archivo tal como avengers.js en lugar
de avengers.controller.js. Todas las dems convenciones todava usan un
sufijo del tipo. Los Controladores son el tipo ms comn de componente as
que esto nos ahorra escribir y an es fcilmente identificable. Yo
recomiendo que elijas 1 convencin y seas consistente dentro de tu equipo.
/**
* recomendado
*/
// Controladores
avengers.js
avengers.spec.js
[Style Y122]
/**
* recomendado
*/
avengers.controller.spec.js
logger.service.spec.js
avengers.routes.spec.js
avenger-profile.directive.spec.js
Nombres de Controladores
[Style Y123]
/**
* recomendado
*/
// avengers.controller.js
angular
.module
.controller('HeroAvengers', HeroAvengers);
function HeroAvengers() { }
[Style Y124]
/**
* recomendado: Opcin 1
*/
// avengers.controller.js
angular
.module
.controller('Avengers', Avengers);
function Avengers() { }
/**
* recomendado: Opcin 2
*/
// avengers.controller.js
angular
.module
.controller('AvengersController', AvengersController);
function AvengersController() { }
Nombres de Fbricas
[Style Y125]
/**
* recomendado
*/
// logger.service.js
angular
.module
.factory('logger', logger);
function logger() { }
Usa nombres consistentes para todas las directivas usando camel-case. Usa
un prefijo corto para describir el rea a la que la directiva pertenece
(algunos ejemplos son un prefijo segn la compaa o un prefijo segn el
proyecto).
/**
* recomendado
*/
// avenger-profile.directive.js
angular
.module
.directive('xxAvengerProfile', xxAvengerProfile);
function xxAvengerProfile() { }
Mdulos
[Style Y127]
Por qu?: Provee una manera fcil de usar tareas automatizadas para cargar
todas las definiciones de mdulos primero, y luego todos los otros archivos
de angular (agrupacin).
Configuracin
[Style Y128]
Rutas
[Style Y129]
Volver arriba
LIFT
[Style Y140]
Localizar
[Style Y141]
/bower_components
/client
/app
/avengers
/blocks
/exception
/logger
/core
/dashboard
/data
/layout
/widgets
/content
index.html
.bower.json
Identificar
[Style Y142]
Estructura Plana
[Style Y143]
Mantn una estructura de directorios plana tanto como sea posible. Cuando
llegues a un total de 7+ archivos, comienza a considerar separacin.
[Style Y144]
Por qu?: Ser DRY es importante, pero no crucial si sacrifica otras partes de
LIFT, es por eso que lo llamo T-DRY. No quiero escribir session-view.html
por una vista porque, obviamente es una vista. Si no es obvio o por
convencin, entonces la nombro as.
Volver arriba
Estructura de la Aplicacin
Pautas Universales
[Style Y150]
Layout
[Style Y151]
Estructura de Carpetas-por-Caracterstica
[Style Y152]
/**
* recomendado
*/
app/
app.module.js
app.config.js
app.routes.js
components/
calendar.directive.js
calendar.directive.html
user-profile.directive.js
user-profile.directive.html
layout/
shell.html
shell.controller.js
topnav.html
topnav.controller.js
people/
attendees.html
attendees.controller.js
speakers.html
speakers.controller.js
speaker-detail.html
speaker-detail.controller.js
services/
data.service.js
localstorage.service.js
logger.service.js
spinner.service.js
sessions/
sessions.html
sessions.controller.js
session-detail.html
session-detail.controller.js
Nota: No estructures tu aplicacin usando directorios-por-tipo. Esto
requiere mover mltiples directorios cuando se est trabajando en una
caracterstica y se vuelve difcil de manejar conforme la aplicacin crece a 5,
10 o 25+ vistas y controladores (y otras caractersticas), lo que lo hace ms
difcil que localizar archivos en una aplicacin estructura en directorios-por-
caracterstica.
/*
* evita
* Alternativa directorios-por-tipo
* Yo recomiendo "directorios-por-caracterstica", en su lugar.
*/
app/
app.module.js
app.config.js
app.routes.js
controllers/
attendees.js
session-detail.js
sessions.js
shell.js
speakers.js
speaker-detail.js
topnav.js
directives/
calendar.directive.js
calendar.directive.html
user-profile.directive.js
user-profile.directive.html
services/
dataservice.j
localstorage.js
logger.js
spinner.js
views/
attendees.html
session-detail.html
sessions.html
shell.html
speakers.html
speaker-detail.html
topnav.html
Volver arriba
Modularidad
[Style Y160]
[Style Y161]
Crea una mdulo raz de aplicacin cuyo rol sea unir todos los mdulos y
caractersticas de tu aplicacin. Nombra ste de acuerdo a tu aplicacin.
[Style Y162]
Solo coloca lgica para unir la aplicacin en el mdulo app. Deja las
caractersticas en sus propios mdulos.
Por qu?: Agregar roles adicionales a la aplicacin raz para obtener datos
remotos, mostrar vistas, u otra lgica no relaciona a la unin de la aplicacin
enturbia el mdulo app y hace ambos conjuntos de caractersticas difciles
de reusar y apagar.
[Style Y163]
[Style Y164]
Dependencias de Mdulos
[Style Y165]
Nota: Esta es una estrategia para consistencia. Hay muy buenas opciones
aqu. Escoge una que sea consistente, que siga las reglas de dependencias
de AngularJS, y que sea fcil de mantener y escalar.
Mis estructuras varan ligeramente entre proyectos pero todas ellas siguen
estas pautas para estructuras y modularidad. La implementacin puede
variar dependiendo de las caractersticas y el equipo. En otras palabras, no te
quedes colgado en una estructura igual pero justifica tu estructura usando
consistencia, mantenibilidad, y eficacia en mente.
Lgica de Arranque
Configuracin
[Style Y170]
Por qu?: Esto hace ms fcil tener menos lugares para la configuracin.
angular
.module('app')
.config(configure);
configure.$inject =
['routerHelperProvider', 'exceptionHandlerProvider', 'toastr'];
toastr.options.timeOut = 4000;
toastr.options.positionClass = 'toast-bottom-right';
////////////////
function configureStateHelper() {
routerHelperProvider.configure({
docTitle: 'NG-Modular: '
});
}
}
Bloques Run
[Style Y171]
Cualquier cdigo que necesite ser ejecutado cuando una aplicacin arranca
debe ser declarado en una fbrica, ser expuesto a travs de una funcin, o
inyectado en el bloque run.
Por qu?: Cdigo que est directamente en un bloque run puede ser difcil
de testear. Colocarlo en una fbrica lo hace fcil de abstraer y mockear.
angular
.module('app')
.run(runBlock);
$document y $window
[Style Y180]
Por qu?: Estos servicios son envueltos por Angular y son ms fciles de
testear en lugar de usar document y window en las pruebas. Esto te ayuda a
evitar que tener que mockear document y window tu mismo.
$timeout y $interval
[Style Y181]
Por qu?: Estos servicios estn envueltos por Angular y son ms fciles de
testear y manejar el ciclo digest de Angular as que mantienen el bindeo de
los datos en sincronizacin.
Volver arriba
Pruebas
Las pruebas unitarias ayudan a mantener el cdigo limpio, as que incluyo algunas
de mis recomendaciones en los fundamentos del testeo unitario con links para
mayor informacin.
[Style Y190]
// y as
[Style Y191]
Nota: Cuando uses Mocha, tambin considera elegir una librera como Chai.
Test Runner
[Style Y192]
Por qu?: Algunos IDE's estn comenzando a integrarse con Karma, tal
como WebStorm y Visual Studio.
Stubear y Espar
[Style Y193]
Por qu?: Sinon funciona bien con ambos Jasmine y Mocha y extiende las
caractersticas de stubeo y espo que ellos ofrecen.
Por qu?: Sinon hace ms fcil cambiar entre Jasmine y Mocha, si quieres
probar ambos.
Headless Browser
[Style Y194]
nalisis de Cdigo
[Style Y195]
Por qu?: Las pruebas son cdigo. JSHint puede ayudar a identificar
problemas en la calidad del cdigo que pueden causar que tus pruebas
funcionen inapropiadamente.
[Style Y196]
[Style Y197]
Coloca archivos de pruebas unitarias (specs) lado a lado con tu cdigo del
cliente. Coloca tus specs que cubren la integracin con el servidor o que
prueban mltiples componentes en un directorio tests separado.
Por qu?: Las Pruebas Unitarias tiene una correlacin directa con un
componente y archivo especfico en tu cdigo fuente.
Por qu?: Tener el spec cerca hace ms fcil al lector del cdigo fuente
aprender cmo se supone que el componente es usado y descubrir sus
propias limitaciones.
Por qu?: Separar specs para que no estn un build de distribucin es fcil
con grunt o gulp.
/src/client/app/customers/customer-detail.controller.js
/customer-detail.controller.spec.js
/customers.controller.spec.js
/customers.controller-detail.spec.js
/customers.module.js
/customers.route.js
/customers.route.spec.js
Volver arriba
Animaciones
Uso
[Style Y210]
Usa sutiles animaciones con AngularJS para hacer transiciones entre estados
en vistas y elementos visuales primarios. Incluye el mdulo ngAnimate. Las 3
claves son sutil, fluido, transparente.
Sub Segundos
[Style Y211]
animate.css
[Style Y212]
Por qu?: Las animaciones que animate.css provee son rpidas, fluidas, y
fciles de agregar en tu aplicacin.
Volver arriba
Comentarios
jsDoc
[Style Y220]
/**
* @namespace Logger
* @desc Application wide logger
* @memberOf Factories
*/
function logger($log) {
var service = {
logError: logError
};
return service;
////////////
/**
* @name logError
* @desc Logs errors
* @param {String} msg Message to log
* @returns {String}
* @memberOf Factories.Logger
*/
function logError(msg) {
var loggedMsg = 'Error: ' + msg;
$log.error(loggedMsg);
return loggedMsg;
};
}
})();
Volver arriba
JS Hint
[Style Y230]
{
"bitwise": true,
"camelcase": true,
"curly": true,
"eqeqeq": true,
"es3": false,
"forin": true,
"freeze": true,
"immed": true,
"indent": 4,
"latedef": "nofunc",
"newcap": true,
"noarg": true,
"noempty": true,
"nonbsp": true,
"nonew": true,
"plusplus": false,
"quotmark": "single",
"undef": true,
"unused": false,
"strict": false,
"maxparams": 10,
"maxdepth": 5,
"maxstatements": 40,
"maxcomplexity": 8,
"maxlen": 120,
"asi": false,
"boss": false,
"debug": false,
"eqnull": true,
"esnext": false,
"evil": false,
"expr": false,
"funcscope": false,
"globalstrict": false,
"iterator": false,
"lastsemic": false,
"laxbreak": false,
"laxcomma": false,
"loopfunc": true,
"maxerr": false,
"moz": false,
"multistr": false,
"notypeof": false,
"proto": false,
"scripturl": false,
"shadow": false,
"sub": true,
"supernew": false,
"validthis": false,
"noyield": false,
"browser": true,
"node": true,
"globals": {
"angular": false,
"$": false
}
}
Volver arriba
Constantes
Globales de Vendor
[Style Y240]
Por qu?: Provee una manera de inyectar libreras vendor que de otra
manera son globales. Esto mejora la testeabilidad al permitirte saber ms
fcilmente cules son las dependencias de tus componentes (evita
abstraciones malformadas). Tambin te permite mockear estas
dependencias, cuando tiene sentido.
// constants.js
angular
.module('app.core')
.constant('toastr', toastr)
.constant('moment', moment);
})();
[Style Y241]
Por qu?: Cuando una aplicacin es separada en mdulos que pueden ser
reutilizados en otras aplicaciones, cada mdulo autnomo debera ser capaz
de operar por s mismo incluyendo cualquier constante de la cual dependa.
Plantillas y Snippets
Usa Plantillas o snippets para ayudarte a seguir estilos consistentes o patrones.
Aqu hay plantillas y/o snippets para algunos de los editores de desarrollo web e
IDEs.
Sublime Text
[Style Y250]
Visual Studio
[Style Y251]
WebStorm
[Style Y252]
Generador de Yeoman
[Style Y260]
Puedes usar el generador de yeoman HotTowel para crear una aplicacin que te
sirve como punto de inicio en Angular que sigue esta gua de estilos.
1. Instala generator-hottowel
2. npm install -g generator-hottowel
4. mkdir myapp
5. cd myapp
6. Corre el generador
7. yo hottowel helloWorld
Volver arriba
Enrutamiento
Enrutamiento del lado del Cliente es importante para crear un flujo de navegacin
entre vistas y vistas de composicin que estn hechas de muchas pequeas
plantillas y directivas.
[Style Y270]
Por qu?: UI Router ofrece todas las caractersticas del router de Angular
mas algunas adicionales incluyendo rutas anidadas y estados.
[Style Y271]
Define rutas para vistas en el mdulo dnde stas existen. Cada mdulo
debera contener las rutas para las vistas en ese mdulo.
Por qu?: Cada mdulo debe ser capaz de funcionar por s mismo.
Volver arriba
Automatizacin de Tareas
Usa Gulp o Grunt para crear tareas automatizadas. Gulp deriva a cdigo sobre
configuracin mientras que Grunt deriva a configuracin sobre cdigo.
Personalmente yo prefiero Gulp ya que se siente ms fcil de leer y escribir, pero
ambos son excelentes.
[Style Y400]
Angular docs
Para cualquier otra cosa, refirete a la API, mira la documentacin de Angular.