-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assess switch from pybind11 to nanobind #2712
Comments
Known issues:
|
See wjakob/nanobind#292 on support for complex. |
Const is still a pain |
I just saw this issue because of a mention in the nanobind repo. Just to clarify: pybind11 handles (If so, note that neither of these two frameworks honors const-ness, so this will likely not do what you want even for the pybind11 side.) |
@wjakob. Yes. It is just an interfacing and convenience issue. Clearly python does not generally care about const (though I guess numpy has some idea). |
The |
|
Thanks @wjakob. Does |
I've updated the branch https://github.com/FEniCS/dolfinx/tree/nanobind to sync with main. |
Another user has made a PR about this exact feature ;) -> wjakob/nanobind#319 (not sure if it's related to FEniCS) |
Thanks for the heads-up @wjakob. I think they are looking for alien life (SETI Institute), which is a bit outside of our domain. |
I mean, FEniCS can be useful for radio astronomy too! 😄 Just as a clarification, my PR (wjakob/nanobind#319) was written for the Python bindings of BLADE, a GPU-accelerated software being used as the DSP-backend on the Allen Telescope Array for astronomy and SETI purposes. |
Thanks to @luigifcruz, this is now merged 🎉 . I just pushed out nanobind 1.7.0 with this change. |
Thanks @luigifcruz, thanks @wjakob! |
Switch (almost?) complete in #2820. Can be merged once new nanobind release made. |
There may be benefits to switching from pybind11 to nanobind (https://github.com/wjakob/nanobind).
This will require a careful assessment, and the blockers resolved.
The text was updated successfully, but these errors were encountered: