-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement storage and api for gate survey questions #4709
Implement storage and api for gate survey questions #4709
Conversation
@@ -0,0 +1,55 @@ | |||
# Copyright 2025 Google Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time flies!
from internals.review_models import Gate, SurveyAnswers | ||
|
||
|
||
def update_survey_answers(gate: Gate, new_answers: OASurveyAnswers): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional nit: This file could be named self_certify_helpers.py
since it contains no classes and consists only of helper functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it would seem odd to have an X_helpers file without having the X file first. I'll stick with the shorter name for now, but keep _helpers in mind.
This should resolve #4695. It is the first part of support self-certification of review gates. Basically, each review team can define some survey questions to screen feature owner review requests. If the answers to those questions indicate that the change is not a risk, then the feature owner will be able to click a button to get approval for that gate rather than wait for human review.
In this PR: